The id for the "Go" button is "edit-submit." This happens to be the same id as the node edit form, which means you get a validation error when you run masquerade on a node edit form. That's not the end of the world, but as one who has spent 45 minutes trying to figure out why my javascript event handlers can't be applied to the submit button, I'd suggest this be changed.

CommentFileSizeAuthor
#3 masquerade-id-conflict-856620-3.patch369 bytesmgifford

Comments

hefox’s picture

hefox commented

Considering form_clean_id, relying on an ID for a form element is, well, asking for trouble.

though, it's odd that the id's are the same; one ID should be edit-submit-1, but it could be due to something (views I think?) flushing the form_clean_id cache between node form and masquerade form creation.

dpearcefl’s picture

dpearcefl commented
Version: 6.x-1.4 » 7.x-1.0-rc5

This is still happening. I'll be happy to submit a patch if we can agree on what the id should be.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new masquerade-id-conflict-856620-3.patch369 bytes

So something like this should resolve this.

Status: Needs review » Needs work

The last submitted patch, 3: masquerade-id-conflict-856620-3.patch, failed testing.

nvahalik’s picture

nvahalik commented
Status: Needs work » Closed (outdated)

This no longer appears to be the case as the #id is not defined explicitly and on pages where another edit-submit is defined, it correctly has another ID.