This happens with PHPTemplate node.tpl.php and both bluemarine and pushbutton.

The problem is with the following

<span class="taxonomy"><?php print $terms ?></span>

That generates

<span class="taxonomy"><ul class="links inline"></ul></span>

Which is invalid XHTML when we use W3C validator

document type does not allow element "ul" here; missing one of "object", "ins", "del", "map", "button" start-tag

The solution is to use a <div> instead of the <span>

CommentFileSizeAuthor
#4 85667.span_.to_.div_.taxonomy.patch1.58 KBbeginner

Comments

lvadillo’s picture

lvadillo commented
Version: x.y.z » 5.1

This I found thanks to the Drupal search system, it's terribly old.
If it's that simple to fix, can someone who know how to do it please. I cannot work with non W3C compliant pages, something quite important nowadays.
Thank you.

be9’s picture

be9 commented

It's due to theme_links() function, which by default renders links in a

    .

    This can be redefined inside your theme.

be9’s picture

be9 commented

Oops, forgot the code tag.

I meant, it's theme_links() that renders an <ul>

beginner’s picture

beginner commented
Status: Active » Needs review
StatusFileSize
new 85667.span_.to_.div_.taxonomy.patch1.58 KB

I confirm that the problem is with bluemarine and pushbutton.
Garland already use div instead of span.

I checked style.css: it's theming .node .taxonomy so having a span or a div won't make a difference.

beginner’s picture

beginner commented
Version: 5.1 » 6.x-dev

The same patch applies cleanly on D6, too.
Please apply on HEAD, and backport to D5.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Version: 6.x-dev » 5.x-dev

Fixed in HEAD, moving to 5.x.

recidive’s picture

recidive commented
Status: Needs review » Reviewed & tested by the community

Marked #252277: Taxonomy term page fails to validate with Bluemarine as duplicate of this one.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Hmm, this was available before several 5.x versions and hasn't rolled out yet? I wasted several hours on this today when I should have been working on the real issue.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Reviewed & tested by the community » Needs work

This patches fixes the XHTML grammar problem, but changes the display: the terms are displayed below the title instead of remaining on the far right (at least in Opera).

The hackish patch I did on #25277 fixes that too, but should be improved, probably by moving the "inline" specification to style.css

recidive’s picture

recidive commented

"This patches fixes the XHTML grammar problem, but changes the display: the terms are displayed below the title instead of remaining on the far right (at least in Opera)."

Ok, do you experience this issue on Drupal 6 and HEAD on Opera?

If so, we need to patch HEAD with a full solution, i.e. adding some lines to style.css, then backport to Drupal 6 and 5.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented

D6 and HEAD have the same UI bug as D5 with this patch applied. Neither looks like the original D5 : the terms are below the node info instead of being flush right with it.

dpearcefl’s picture

dpearcefl commented
Status: Needs work » Closed (won't fix)

Considering the time elapsed between now and the last comment plus the fact that D5 is no longer supported, I am closing this ticket.