Notices when installing Product Reference

Got the same error when installing from scratch (Ryan's github branch of Commerce, latest CVS of Rules and Entity).

Also got the above mentioned notices when enabling Product Reference (and Cart and Checkout along with it).

The notices are thrown from here:

// If no weight specified, make sure the field sinks at the bottom.
if (!isset($display['weight'])) {
  $weights = array();
  foreach (field_info_instances($instance['entity_type'], $instance['bundle']) as $existing_instance) {
    if ($instance['field_name'] != $existing_instance['field_name']) {
      $weights[] = $existing_instance['display'][$view_mode]['weight'];
    }
  }
  foreach (field_extra_fields($instance['entity_type'], $instance['bundle'], 'display') as $extra) {
    $weights[] = $extra['display'][$view_mode]['weight'];
  }
  $display['weight'] = $weights ? max($weights) + 1 : 0;
}

With the offending line being:

$weights[] = $existing_instance['display'][$view_mode]['weight'];

My Drupal instance is a few weeks old, and I remember you making changes for alpha6, so maybe updating to a newer HEAD would fix this.

I also get the following in the Cart view:

Debug: 'Missing handler: field_data_line_items line_items_line_item_id relationship' in views_get_handler() (line 724 of /home/bojan/public_html/drupal/sites/all/modules/views/views.module).

Which might be related to the first error...

Installed latest D7 HEAD, and all the latest modules.
The critical error is no longer there.

However, the two notices remain.

This still an issue?

@rszrama
As far as I know, they are gone (it was due to Entity, you found it on irc, fago said in his own queue that it's fixed).

I will do a reinstall to confirm.

As best as I can tell, the notices were coming from the creation of Price fields and a Product Reference field on the installation of the Product and Product Reference modules. I've updated the code to use the proper view modes when creating these fields, because the Product Reference field creation was using an outdated view mode and the Price field creation wasn't changing the view modes specified based on the type of entity the field was being added to. See the fix here:

http://github.com/rszrama/drupalcommerce/commit/1202c6a8fa4749984727b9b9...

Committing to CVS now so it can be tested. Use the latest versions of Views, Entity, and Rules, too.

using the latest dev versions of everything (including core) I'm still getting these notices...

@aristeides, I imagine you have a failed install, where some fields were not successfully created.

You can figure out where the messages are coming from with the Commerce Devel module. But it's likely you'll have to uninstall and reinstall all commerce related modules. #858722: Cannot reinstall Commerce modules after uninstall due to field deletion failure, which I think you're in, has information about how to do a manual uninstall.