Plugins that provide "use fields" = false broken

FYI... I also just checked in the latest changes I made to the MediaFront module to CVS, if you would like to check it out and see for yourself. The CVS tag is DRUPAL-7--1.

Thanks again for your attention to this.

Travis.

Here is the latest patch for Drupal 7.

I don't think that this is even an issue with Drupal 6 since it uses a different database library than Drupal 7. So, I am pretty sure that this is only required for Drupal 7.

Basically the rundown here of what this is doing....

If you provide ANY plugin that specifies that it does not use fields within the plugin declaration, the current implementation will crash since it tries to run a query similar to SELECT FROM {....... The problem here is we are not providing any fields to SELECT. We need to at least say SELECT * FROM {..... if no fields are provided. So, the fix above basically tells the view, that if they do not use fields, to go ahead and grab all fields for the base table in the query.

This works very well for my needs, where I cannot force the user to specify the fields that my widget requires ( a media player ). You see, my media player definitely needs fields within each row to function, but the user would never know which ones since it changes for almost every use case and implementation I can think of. By only returning the fields that they added in the view ( which is what the current implementation of Views for Drupal 7 does ), I have no choice but to declare my widget as one that does not use fields, and then hope that views passes me back ALL fields for the base table. This is what this patch brings to the table.

Let me know if you need any more info.

Thanks for your attention in this matter.

Travis.

This issue has unfortunately come up again, and is keeping adoption of MediaFront 7x from happening for those who are using Views 3x.

Here is the related issue queue item in MediaFront that is caused by this problem. http://drupal.org/node/1059868

Here are patches for both Drupal 6 and 7 that fixes this issue.

Thanks,

Travis.

Here are the latest patches that use '--no-prefix' so it can be applied relatively. There is a patch for both 6.x-3.x and 7.x-3.x.

Thanks,

Travis.

I just found a MUCH more elegant way to do this which is the same between the Drupal 6 and Drupal 7 versions. It is also much more explanatory on what is going on and what I need to have this fixed.

Well, I think it would, but my widget declares the following...

/**
 * Implementation of hook_views_plugins
 */
function mediafront_views_plugins() {
  $path = drupal_get_path('module', 'mediafront');
  $plugins = array(
    'module' => 'mediafront', // This just tells our themes are elsewhere.
    'style' => array(
      'mediaplayer' => array(
        'title' => t('Media Player'),
        'help' => t('Shows this view as a Media Player.'),
        'handler' => 'mediafront_plugin_style_player',
        'theme' => 'mediafront_player_view',
        'path' => "$path/views",
        'theme path' => "$path/views",
        'uses fields' => FALSE,
        'uses row plugin' => FALSE,
        'uses options' => TRUE,
        'uses grouping' => FALSE,
        'type' => 'normal',
        'even empty' => TRUE,
      )
    )    
  );
  return $plugins;
}

I don't need a row plugin, so I declared 'uses row plugin' as FALSE. My widget is simply a MediaPlayer style where I take the view results and populate a media player playlist from that view. I didn't see the need for a row plugin since I am passing along all the rows to my widget to render.

And as for your second notion, I am not totally sure that would work in a style plugin. I have always assumed that the style plugins really should not have any control over the query, but maybe that would work. Let me know otherwise.

Thanks for your attention to this.

Travis.