Color index 255 out of range in image.gd.inc

Good to go for me, someone else willing to rtbc?

gd_transparency.patch queued for re-testing.

Happy to mark as RTBC.

gd_transparency.patch queued for re-testing.

gd_transparency.patch queued for re-testing.

There are a couple of other instances of this pattern in the code. Shouldn't we fix those for consistency?

Adding check other occurences of this pattern. Moving to d8 as it needs to be fixed there first.

#8: colour-index-859304-8.patch queued for re-testing.

reroll for D8. patch successfully tested on both D7 and D8.

Not sure if I can really rtbc but given that #11 obviously involved a review of my patch.....

Thanks for working on this patch. It could use an automated test before it is committed. If you need help you can ask the friendly people in the #drupal-contribute IRC channel.

Related issues:
#100276: Transparent pixels become black when image is resized.
#204497: Make the background fill color configurable where image styles result in blank space

#8 works fine for me =)

#8 RTBC on D 7.22, fixed two flaws:

Warning: imagecolorsforindex(): Color index 6 out of range in image_gd_create_tmp() (line 310 of /var/www/modules/system/image.gd.inc).

... the gif which popped that error, when passing through unpatched D 7.22, was having that color index trashed on the resulting thumbnail. Patch in #8 also solves that.

Thank you much, and please backport this so we don't have to reapply patch at next upgrade.

Any takers for #11 reroll + test?

11: 859304_11_imagecolorsforindex.patch queued for re-testing.

#375062: imagecolorsforindex() Color index nnn out of range in GDToolkit is similar to this issue

The patch in #8 no longer applies - it looks like this was fixed in D7 here: #375062: imagecolorsforindex() Color index nnn out of range in GDToolkit

Let's close this then.