Posted by Jakob Stoeck on July 20, 2010 at 3:10pm
7 followers
| Project: | Vertical Tabs |
| Version: | 6.x-1.x-dev |
| Component: | User interface |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Issue Summary
On some designs the summary below the vertical tab headlines is too large and should be disabled. A patch could easily be written changing line 344 of vertical_tabs.module:
'callback' => isset($element['#summary_callback']) ? $element['#summary_callback'] : $key, into 'callback' => isset($element['#summary_callback']) ? $element['#summary_callback'] : null, plus adding an if-else-statement and an admin checkbox.
I'd make a patch if someone else needs this, too.
Comments
#1
The attached patch is how I implemented this feature based on above suggestion.
#2
This worked like a charm on the latest dev. Thanx!
I know patches should be marked RTBC after a couple of people have tested/reviewed them, but I think this is a no-brainer modification. So, I am going ahead and marking it RTBC.
PS: would you care to take a look at this somehow-related issue if time permits? : #869358: Don't display empty settings in summary + Don't display rest of the settings in summary if default setting is set to 'Disabled'
#3
If the summary is too large it should be fixed in the corresponding module that generates it, rather than causing a usability regression.
#4
I am not sure I follow. Do you mean to say that you consider hiding summaries a usability regression? If yes, allow me to kindly disagree.
So, in this case we have two different opinions on a UI feature. My opinion is that in such cases, instead of starting flame wars of what is more correct and what not, we should make it so that the feature in question is optional and leave it up to each user to decide if they enable it or not. The default should be what the majority expects/wants, but that should be allowed to be changed.
This patch does exactly that it provides a feature and it makes it optional. So, IMHO it should be in.
On the other hand, I think we can always have the summaries display as an on-hover pop-up instead. This would not make it such a usability regression now. Would it?
#5
I agree with klonos. Providing an option to disable summaries on tabs is useful. Since vertical tabs are the only tabs I know with summaries (browser, OS, other web pages) I think they aren't needed many times and just blow up the interface. We don't want to delete them but give the option to non-programmers when needed.
#6
I would also like the option to hide the summaries. I prefer to have just the tab titles displayed and nothing else.
For example, having a dozen terms causes the vocabulary tab to be huge.
#7
This needs to be addressed and a really obvious and simple solution has already been provided. Can we please move on with it?
@NaX: care to reroll this + add the option to display the summary as a tooltip instead?
#8
I just saw in action what mkinnan talks about in his example in #6. The patch in #1 still works in the latest dev (manually applied though). Did you try it?
#9
The patch in #1 worked for me.
#10
Is this going to be commited?
#11
I agree w/ mkinnan and klonos - the Vocabularies tab is especially problematic when there are long terms or a very large number of terms. Because of the nature of one Drupal installations I manage, nodes can have upwards of forty keywords, and this definitely makes the node edit form a lot more difficult to use because all the terms get displayed in the tab summary. Also, when a content type is composed mainly of custom CCK fields that are organized into many fieldgroups, there are only a few tabs that print a summary at all. In that case it would seem more consistent to exclude the summary altogether rather than only having it appear on only two or three tabs (depending on the permissions of the user.)
I tested the patch with the 6.x-1.x-dev release of the module - worked for me!
#12
+1 for commiting this
In my usecase the summary doesnt make any sense and it screws up the layout..
i'm currently hiding it with CSS.