Great work on a great module! I've been using it gratefully since it also counts filefield items. Thnx.

One minor thing which wasn't entirely clear to me: when I press reset all on the my_download_count page, it resets all the counters all over. It might be more logic if this would only reset the counters on the my_download_count page. (I am logged in as user 1).

Just my two cents

Comments

WorldFallz’s picture

WorldFallz commented
Status: Active » Postponed

ah... interesting point. I could either just not show the links on the 'my' version of the page or alter the module to actually take user id into consideration. I think for the time being, I'll just remove the links (i'm anxious to get a stable release out). This can always be considered as a future feature.

Thanks for the report.

ckng’s picture

ckng
Primary language English
commented
Status: Postponed » Active

Since now we've 2.0 stable and {download_count_statistics} data, it is more reasonable to clear the {download_count} table and maintain the summarized data in {download_count_statistics}.

by only resetting the {download_count}
- housekeeping to reduce the DB size
- download stats no longer lost with {download_count_statistics}, except top users, nodes

few things need changing then
- top downloaded files is more accurate to get from {download_count_statistics}
- another summarized table for users and nodes
- {download_count} serves as a temporary store before it gets calculated and purged, duration configurable by user
- views download count, get from {download_count_statistics} instead of GROUP BY

Update: don't think this is necessary, a proper index keys will do a good job. a more thorough change is preferred
- to store the summarized stats by the duration instead having the DB recalculate every time, i.e. hourly, daily, weekly, monthly, yearly - per fid, per user, per node
- have top downloads listing by hourly, daily, weekly, monthly, yearly by fid, user and node
- this would be best suited to use RRDtools? (found this, http://drupal.org/project/rrdtool, never try though)

Side question:
What's the different between 'Top Downloaders' & 'Top Downloaded Users'? They are the same code wise.

ckng’s picture

ckng
Primary language English
commented
Title: Reset only my_download_count » Purge {download_count}, summarize statistics

Update the title to better reflect the request.

WorldFallz’s picture

WorldFallz commented
Status: Active » Closed (won't fix)

I don't anticipate making any change to the d6 version at this point.

What's the different between 'Top Downloaders' & 'Top Downloaded Users'? They are the same code wise.

The query is different. "Top Downloaders" the the uses downloading the most files. "Top Downloaded Users" are the users who's files (they uploaded) are the most downloaded.