Hi all,

I am coming from #698174: Remove all calls to $handler->options() where it was found running the command grep "function options(" . -rn with Ubercart 2.3 that the ubercart views fields are currently not compatibility with Views 3.

./sites/all/modules/ubercart/uc_product/views/uc_product_handler_field_weight.inc:13:  function options(&$options) {
./sites/all/modules/ubercart/uc_product/views/uc_product_handler_field_price.inc:13:  function options(&$options) {

I don't know programming but wanting to use Ubercart and hope these fields can be updated to be compatible with Views 3 (another module I am using).

Regards

CommentFileSizeAuthor
#2 views-compability.patch2.04 KBdawehner

Comments

Flying Drupalist’s picture

Flying Drupalist commented

subscribe

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new views-compability.patch2.04 KB

Here is a patch

I didn't tested the patch.

Island Usurper’s picture

Island Usurper commented

dereine, would your patch also work with Views 2? If it doesn't, I probably shouldn't commit it until Views 3.0 is out.

dawehner’s picture

dawehner
Primary language German
commented

It works for 2.x, too.

option_definition api was introduced somewhere in the beta of 2.0, and replaced options api.

Island Usurper’s picture

Island Usurper commented
Category: support » bug
Status: Needs review » Fixed

It seems this fixes a subtle little bug, too, so it's got that going for it. Changing the price format to "Numeric" wouldn't get saved before this patch, though it did work for weight. Odd.

Anyway, thanks for the patch. Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.