Closed (fixed)
Project:
Domain Admin
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
22 Jul 2010 at 10:09 UTC
Updated:
6 Aug 2010 at 20:50 UTC
A user with the permission "administer domain primary links menu" can create menu items but can not edit or delete those items.
The same probably goes for "administer domain secondary links menu".
On the other hand he can edit the menu:
admin/build/menu-customize/primary-links/edit
This I think should not be allowed. I have not checked if this is domain sensitive.
Comments
Comment #1
nirbhasa commentedComment #2
nirbhasa commentedThe lack of access to menu items is now fixed in HEAD
However a user with "administer domain primary links menu" and assigned to a domain cannot edit the default primary links menu, unless the default primary links menu is assigned to the domain.
Comment #3
brt commentedThanks for the quick fix.
Now testing HEAD.
The remaining problem is that a user with "administer domain primary links menu" can rename the menu (not menu items) and it affects all domains.
"Edit menu" -> /admin/build/menu-customize/primary-links/edit
is allowed, so menu title and description can be changed across all domains.
The effect I want is when I remove lines 132 and 133
132 $items['admin/build/menu-customize/%menu/edit']['access callback'] = '_domain_admin_menu_access';
133 $items['admin/build/menu-customize/%menu/edit']['access arguments'] = array(3);
Users can edit menu items but not the menu itself.
Comment #4
nirbhasa commentedThat seems fine by me. Latest revision committed to HEAD
Comment #5
nirbhasa commented