Remove string: "Credit card number validation is broken in Ubercart 1.0."

I don't think you have placed this issue in the correct project issue queue, is it at all related to the sagepay module?

I am moving it to Ubercart right now as I think it belongs there although I must warn you that drupal 5.x version of the modules are are slowly moving to be unsupported (or very lightly supported).

That string is printed by the Drupal 5 version of uc_protx_vsp_direct.module, so yes, the support request was in the correct issue queue.

Right, sorry about that. I have inherit this module after some development, and that was a string that was present from day 1 from the previous development so I didn't have it present in my mind.

IIRC, there was some kind of warning or issue with CC validation in Ubercart (maybe TR can throw some light into this?) but to be honest I am not surei f that warning is still valid, I think you can ignore it and eventually, if the CC ubercart validation fails for you in any case, you can disable it. I generally don't use CC validation, I just let sagepay does its thing and in case of a cc number error, it will complain.

But you are right in that such a warning might be confusing, maybe I'll just remove it.

a.=

I don't know what the module author had in mind when he added that "broken" message. Ubercart does only minimal validation of a number before sending it off to the gateway where the detailed validation is performed. Ubercart checks to see if the number is all digits, then computes the checksum according to the Luhn algorithm to ensure the number passes, then checks the first digit of the card number against the enabled card types. It's that last check which might cause a problem for a UK based payment gateway like Sage Pay. #270788: Double big bug : impossible to create an alias for user/register mentions that this first digit check is ambiguous in the case of International Maestro cards (and other cases not mentioned in that thread), so the first digit check really should be re-written. Unfortunately, to check it properly you need to look at the first four or five digits and compare them against a big table of card issuers.

Drupal 5 is no longer supported.