Pager doesnt work.

This code do for your default views

function mymodule_views_pre_execute(&$view) {
	
	if ( $view->name == 'privatemsg_mailbox'   ) {
		$view->build_info['count_query'] = 'SELECT (pm_message.mid)  FROM {pm_message} pm_message INNER JOIN {pm_index} pm_index ON pm_message.mid = pm_index.mid WHERE (pm_index.deleted = 0) AND (pm_index.uid = %d)';
	}
}
CommentFileSizeAuthor
#5 privatemsg_views_861560.patch1.04 KBcrea
#5 privatemsg_views_861560.patch1.04 KBcrea
#4 privatemsg_views_861560.patch989 bytescrea

Comments

crea’s picture

crea commented
Priority: Normal » Major

Thanks for the tip, but the query you're suggesting is wrong. There's no GROUP BY or DISTINCT in it thus it doesn't represent base query. You are simply counting messages, we OTOH need to count threads.
But I would like to avoid the approach, cause it works in a limited way and is closely tied to the supplied view. Would be best to work out a solution that worked for all views.

crea’s picture

crea commented
Title: Pager do not work » Mailbox pager does not work
crea’s picture

crea commented

For anyone interested, I described the problem in the Views queue: #904284: Count query optimization code only checks $this->groupby and not presence of "aggregate" fields.

crea’s picture

crea commented
Status: Active » Needs review
StatusFileSize
new privatemsg_views_861560.patch989 bytes

Attaching temporary fix until the aforementioned request is answered

crea’s picture

crea commented
StatusFileSize
new privatemsg_views_861560.patch1.04 KB
new privatemsg_views_861560.patch1.04 KB

Better patch from the root of the module.

crea’s picture

crea commented

I've committed the patch above to the dev branch. Not closing this issue to wait for proper solution.

crea’s picture

crea commented
Title: Mailbox pager does not work » Mailbox pager count query optimization fails
Category: bug » task
Status: Needs review » Active

Ok, since this is fixed in dev, changing to a task.

crea’s picture

crea commented
Priority: Major » Normal