I used this module on a site I'm developing in 5.0 (http://www.andy-lowe.com/uberdev/)and figured I could post the simple fix... It's just a tweak to work with the new forms API.
Change the return in smileys_admin_form():
<?php
// Was: return drupal_get_form('smileys', $form);
return $form;
?>
Change the return in smileys_admin_add():
<?php
// Was: return smileys_admin_form($edit);
return drupal_get_form('smileys_admin_form', $edit);
?>
Also, you need a file in the module directory called smileys.info that contains the following:
name = Smileys
description = "A filter that substitutes ASCII smileys with images."
And this is up to individual discretion, but because of the new layout for the admin section, I changed the paths in smileys_menu() to point to admin/build/smileys instead of filters... seemed to be the place to go, since that category also contains url aliasing and themes. (similar type settings..)
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | smileys_drupal5_0.patch | 9.42 KB | Gurpartap Singh |
| #4 | smileys_drupal5.patch | 9.45 KB | Gurpartap Singh |
Comments
Comment #1
rszrama commented(should've been more clear in the last post... there are many changes to change the paths. I just replaced all instances of "filters" with "build")
Comment #2
arne@dbyte.nl commentedI was also working on a 5.0 rewrite of smileys because i made some new stuff (http://drupal.org/node/70130) in it and my test server runs drupal 5.0
i had it almost working except the admin_form part. so i will try if it will work at the and of the week.
Comment #3
rszrama commentedGood, I'd love to implement your smiley select for our forums as well!
Comment #4
Gurpartap Singh commentedI have completed the Fapified port of smileys for Drupal 5.x. Hope it helps others. Changed a lots of visual stuff. Basic functionality code is same. Fapifying it got me to include some more functions and hence bigger patch. Rewrote block code, now using theme_table().
Create the
smileys.infofile including this:I'm sure there must be something lame in there. So please review for me ;)
Comment #5
Gurpartap Singh commentedFixed a variable typo.
Comment #6
Gurpartap Singh commentedHere's the release:
http://drupal.org/node/97933
Comment #7
Gurpartap Singh commentedComment #8
(not verified) commented