Folks,
I've been wondering what the strange little circles I've been seeing in my embedded phpbb pages are - and I've just realised that they're Danland's menu-leaf icon.
Removing the generic [i]ul li[/i] from the start of the style definition in style.css seems to have fixed the issue without breaking the menus themselves, since they use [i]li.leaf[/i], with minimal modification to other modules. The bullet for [i]ul li[/i] items in page (and other) content changes from the menu-leaf to a default solid bullet, but since very little other styling from the theme is carried into the page content, this is (imho) no bad thing, and increases rather than reduces clarity and consistency.
I've not found any issues elsewhere arising, but it's entirely possible that there's something I've missed.
Test environment...
Drupal 6.16 and 6.17
Danland 6.x-1.10 and 6.x-2.0
phpbb 3.0.6 and 3.0.7, using prosilver-embed style
phpbbforum integration module 6.x-2.0-beta11 and 6.x-2.0-beta12
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | danland-no-ulli.png | 60.89 KB | AdrianC-1 |
| #3 | danland-ulli.png | 61.8 KB | AdrianC-1 |
| #3 | garland.png | 52.02 KB | AdrianC-1 |
Comments
Comment #1
danpros commentedHi,
Yes I use styling for ul li like in Garland. How about if you using Garland? are you facing the same problems?
Dan
Comment #2
AdrianC-1 commentedSorry - should have said that. Garland is absolutely fine.
Comment #3
AdrianC-1 commentedScreenshots... Always useful...
Comment #4
danpros commentedHi,
It seems I'm missing few codes :) Can you use firebug and find the classes for that ul li, that image is the background, and can be disable by adding
background: none;but it need the classes for that (i.e. ul.inline li)Comment #5
AdrianC-1 commentedDan,
I've dropped you a line via your profile with details in.
Comment #6
danpros commentedHi,
It's seem the problems coming from the module too, you can reporting this to the module maintainer to including Danland in their CSS fixes. I'll close this, but please re-open if you got a clue about this issue.
Thanks,
Dan
Comment #7
AdrianC-1 commentedThank you, Dan, for your time and effort investigating this.
Extending the Garland "fix" CSS shipped with phpbbforum strips all the bullets from the Danland menus in addition to the spurious icons. Support for phpbbforum seems to be rather lacking, unfortunately, so I'm sticking with the removal of generic ul li. The other option would be to identify all of the li classes used by phpbbforum and any other modules which may have a similar issue and amend the Danland CSS to explicitly ignore those. Yes, there's a slight knock-on in that generic li in content reverts to normal bullets, as I mentioned earlier, but - and this is purely personal opinion - I think that's actually a benefit not a downside.
Thanks, too, for a rather excellent theme - good enough that it made me break my "No fixed-width themes" golden rule...
Comment #8
danpros commentedHi,
When I investigating your site actually you can disable it for specific part from the ul li since they use classes for the ul li too.
Yes fixed is not that bad :). In version 3.0 I'll try to adding rounded corner and redesign the theme, yes like Zen classic and current Zen (Danland 6.x-1.x and Danland 6.x-2.x is classic). The current menu bar also changes to tabbed navigation bar, change the slideshow design etc.