When trying to run the update function for this module, I got the following fatal error:

An unrecoverable error has occurred. You can find the error message below. It is advised to copy it to the clipboard for reference.
Please continue to the error page

An error occurred. http://www.mysite.com/update.php?id=21&op=do
Fatal error: Call to undefined function _globalredirect_get_settings() in /path/to/drupal/sites/all/modules/contrib/globalredirect/globalredirect.install on line 31

CommentFileSizeAuthor
#11 modules_globalredirect.7.x-1.x..local_.patch11.51 KBpillarsdotnet
#11 modules_globalredirect.master..local_.patch10.05 KBpillarsdotnet
#8 modules_globalredirect.patch433 bytespillarsdotnet

Comments

pickerel’s picture

pickerel commented

The missing function is in globalredirect.module. I copied it over to the .install file and ran update with no problem.

adeb’s picture

adeb commented

Thank you, solved my problem.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Fixed

The easy solution was to add a drupal_load('module', 'globalredirect') right before calling the function. This has been fixed in the lastest CVS:
http://drupal.org/cvs?commit=434744
http://drupal.org/cvs?commit=434746

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

SebCorbin’s picture

SebCorbin commented
Version: 6.x-1.3-alpha1 » 7.x-1.3
Status: Closed (fixed) » Reviewed & tested by the community

I got the error back while upgrading from D6, the patch fixed the error.

bfroehle’s picture

bfroehle commented
Status: Reviewed & tested by the community » Fixed

SebCorbin: This was already fixed in the development branch after 7.x-1.3. See http://ftp.drupal.org/files/projects/globalredirect-HEAD.tar.gz

-Brad

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

pillarsdotnet’s picture

pillarsdotnet commented
Version: 7.x-1.3 » 7.x-1.x-dev
Status: Closed (fixed) » Needs review
StatusFileSize
new modules_globalredirect.patch433 bytes

Apparently the fix in #3 didn't survive the Great Git Migration.

bfroehle’s picture

bfroehle commented
Status: Needs review » Closed (fixed)

It was fixed right here: http://drupalcode.org/project/globalredirect.git/commitdiff/94534de

The confusion is coming from #1045842: Development releases link to wrong branch which is that all of the fixes are going into the master branch which is != to the 7.x-1.x branch.

pillarsdotnet’s picture

pillarsdotnet commented
Category: bug » support
Status: Closed (fixed) » Active

So should I be pulling from 7.x-1.x or from master? Or both?

And when I submit a patch relative to "master" which is different from "7.x-1.x" should I set the version to "<none>" since there is no version option labeled "master" ?

Wouldn't it be simpler to just merge the changes in master back into the 7.x-1.x branch?

Or delete the 7.x-1.x branch and then rename master to 7.x-1.x ?

Or rename the master branch to 7.x-2.x and release against that?

pillarsdotnet’s picture

pillarsdotnet commented
Category: support » bug
Status: Active » Needs review
StatusFileSize
new modules_globalredirect.master..local_.patch10.05 KB
new modules_globalredirect.7.x-1.x..local_.patch11.51 KB

Well, I answered my own question. I checked out "master" and it totally broke my site.

Okay, I've created a functional local branch combining the 7.x-1.x branch with the master branch.

So here are two patches.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

This is now fixed on the correct branch, 7.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.