Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Update the smileys.module to:
- support uploading of smileys handled by the fileapi;
- use the standard theme('table') instead of having it's own defined tables;
- update to recent menu() changes by the tabs-patch;
- use consistent words like smiley OR emoticon, not both (I personally prefer the word emoticon);
- if the above option becomes emoticon, make an update script for the db and rename the module from smiley.module => emoticons.module;
- add the ability to use a emoticons_bar() for JavaScript enabled browsers to simply click and insert emoticons.
Comments
Comment #1
Steven commentedYou sent me some of these changes a long time ago, but I didn't like the implementation much: the Javascript code in particular was messy and unorganised. I sent you a bunch of comments back then, do you still have them?
Also, I don't think renaming the module is a good idea: it would probably confuse people ("where did smileys go?") plus the term smileys is a lot friendlier I think. The usage of 'emoticons' was added later in the help tips I think, afaik it's not used in the code anywhere.
File API smiley upload sounds interesting, but it might be tricky to combine it with the current method.
If you really want to do this, go ahead, but I was looking forward to updating my contrib modules so I can get familiar with the tabs patch post-exams ;).
Comment #2
Gurpartap Singh commentedAll the above suggestions are in Drupal 5.x release of module. Except smiley upload and renaming the module. No chance renaming it now, it's just either late or something else :)
Comment #3
(not verified) commented