Posted by roball on July 23, 2010 at 1:33am
12 followers
| Project: | Transliteration |
| Version: | 7.x-3.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Issue Summary
Currently, when the "Transliterate file names during upload." checkbox is ticked at admin/settings/file-system, all whitespace characters will be replaced by an underline (_) character. Can we please have a checkbox that allows unticking that behaviour? More than one spaces side by side should still be reduced to a single one, but if you are using "pretty" self-explaining filenames for files that are attached to a node, spaces look prettier than underlines, so it would be nice NOT to force replacing by an underline.
Comments
#1
Same problem here with 5.x version..
#2
I think it's better to keep the version at the highest one having this problem.
#3
Anyone up for a patch?
- Add a checkbox to the settings.
- Check its value when processing a filename.
#4
There seem to be a few of these issues. Patch in this issue: #973936: Filename transliteration: Space replaced by underscore rather than defined separator character
#5
I have marked the other node as duplicate of this one.
#6
Repost from http://drupal.org/node/973936#comment-4668844
This patch provides some configuration options regarding spaces. It defaults to the current behaviour, with options to keep spaces, remove them altogether, or replace them with either an underscore or dash character.
#7
Patch also applies to D7 version. This one's cleaned up slightly.
#8
There was another issue that requested to have this setting for the '@' character, and probably more will come, so how about we deal with all of them in a single patch?
#9
Thank you for working on this. Could we keep brackets too?
I often name my downloadable documents in the format:
[name with spaces] [Version Number] (last updated date).pdf
#10
Have you tested the patch? There's an option for brackets too..
#11
Any chance to get this into the next release?
#12
Before this patch, my white spaces were getting replaced with underscores when I wanted hyphens. With the patch, and with the preferred separator set to "-" and my Spaces set to "replace by separator," the space is removed by not replaced. Same result if I set it to "no action (do not replace)." Things other than spaces seem to be converted properly.
I had to apply much of the patch by hand, as it didn't apply cleanly (being almost a year old), so maybe I missed something? (Although I've double-checked and can't figure out what.) Could someone re-roll for the latest version?
#13
Attached patch is an update of #8. It is D7-only, as #8 is.
As reported in #12, 'space' handling wasn't working. That is added. The patch contained a '\s' (whitespace like space, tab, ..). I left that one in.