Does this is both IE6 and FF/1.5.07

Create a form that uses '#autocomplete_path' => 'user/autocomplete' and then prefill the field with a known user of the system using the '#default_value' property.

Then, display the form. Put the carrot in that form field and then start hitting "backspace" to delete the user's name. When you get to the end and the user's name is gone, keep hitting the backspace key.

Watch what happens to IE or FF when you do this.

CommentFileSizeAuthor
#18 autocomplete_js.patch-2694 bytesAnonymous (not verified)
#16 autocomplete_js.patch-1668 bytesAnonymous (not verified)
#15 autocomplete_js.patch666 bytesAnonymous (not verified)
#14 autocomplete.js.patch02895 bytesAjK
#11 autocomplete.js.patch01599 bytesAjK

Comments

AjK’s picture

AjK commented

I found an easier way to reproduce this. As a node administrator, edit a node. In the "Authoring information" section the "Authored by" field is an "autocomplete" type textfield.

Just keep hitting the backspace key repeatedly against the user's name in the textfield

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

When I do this, after the first unnecessary backspace Firefox skips me back a page as though I've hit the back button. If I keep hitting it, it skips me back another page, etc. I don't know that this is considered "broken" but is definitely "annoying." But that might have more to do with Firefox than Drupal's JS...

What behaviour am I looking for?

asimmonds’s picture

asimmonds commented

On my system,
In Firefox (1.5.07 and 2rc1), the browser's content area goes completely black after the first backspace in the empty textfield, the second backspace goes back a page (it shouldn't as the textfield should still have focus)

In IE6, after the first backspace, the content area goes blank with a javascript error notification in the status bar. This error is 'Line:217, Char: 5, Error: 'this.style' is null or not a object.

chx’s picture

chx commented

That Firefox behaviour is usual, I might say. When using my Internet bank, it sometimes also navigates away from the page. Mapping backspace to back is just asking for trouble.

AjK’s picture

AjK commented

But when "back keying", between the last latter of the user name and then "page back feature", I get a broken screen that's mostly white with a black bar across the bottom. The next back key does send the browser back a page like stated. Is that normal behaviour?

In IE6 I just get the white screen with black bar. Page stays broken until you do a page refresh.

Despite that fact, the "carrot" focus is in a textfield so backing up pages certainly isn't behaviour is usual for any browser. It should just not go "anywhere" other than sit there waiting for user to type input.

AjK’s picture

AjK commented

Worth noting that Pave the way for integration of jQuery into core http://drupal.org/node/69786 at comment #76, backspacing was reported to produce strange results.

I don't know if this issue is related to that in some way.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

I tried to repeat this as the directions in comment #2 stated and I couldn't even repeat the problem. I tried Fx1.5.0.7 and IE6.0 and Fx2.0rc2. None of them exhibited the behavior. These were on a mix of Windows XP Home and Pro.

Can we say for sure this is a Drupal bug and not a browser bug?

What could we even do to fix this?

chx’s picture

chx commented
Status: Active » Closed (won't fix)

Let's sum up. I talked with Steve[n|] about this, neither of them wanting to fix this -- even if there is something to fix. Greggles hints there is none. Henceforth the best that can be done to grab a shovel and bury this.

chx’s picture

chx commented

Typo in regex: Steve(n|)$

Zen’s picture

Zen commented
Title: autocomplete fields can break browser » Backspacing in autocomplete fields can break browser
Version: x.y.z » 5.x-dev
Status: Closed (won't fix) » Active

I can confirm this in FF2, Opera 9.02 and IE 6 on Windows and Linux. Backspacing in an autocomplete field leads to a page similar to this: http://drupal.org/files/issues/screehshoot.png (from the other issue).

This occurs in 5. Doesn't occur in 4.7.

-K

AjK’s picture

AjK commented
Status: Active » Needs review
StatusFileSize
new autocomplete.js.patch01599 bytes

OK, nothing worse than a critical issue popping up just when RC1 is around the corner to wreck your day so lets put it to bed.

I know those involved didn't want to discuss it and just buried the issue but at least here's a patch to look at that shouldn't need massive amounts of digging to resolve.

This patch basically fixes the problem in FF completely. However, it only part fixes it in IE6. The original problem is fixed but in IE6 the popup now appears in an offset position (to the right). The real problem I cannot supply a more full fix is that I'm no javascript expert. I just did enough to locate where problem appears to be occuring. If some js experts would like to look closer than I'm sure some bright ideas will follow.

AjK’s picture

AjK commented
Status: Needs review » Needs work

Ok, my comments above are bo**ox. The problem is still there. Basically, if you backspace nice and slow, one key at a time, when you've deleted the field completely, all is well. But if you take a "run up" at it (i.e. keep hitting the backspace quickly and overrun the number of characters in the form field) the bug will appear. Patch or no patch.

AjK’s picture

AjK commented

Here's what the javascript console on FF outputs:

Error: Error in parsing value for property 'display'.  Declaration dropped.
Source File: http://example.com/modules/system/defaults.css
Line: 43

Error: this.style has no properties
Source File: http://example.com/misc/jquery.js
Line: 1
AjK’s picture

AjK commented
Status: Needs work » Needs review
StatusFileSize
new autocomplete.js.patch02895 bytes

Ok, Steven and Heine suggested blocking backspace key if the field length decreases to zero (block in both key up and keydown events). This at least has fixed the problem for me.

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new autocomplete_js.patch666 bytes

ok this seems better without a hack.

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new autocomplete_js.patch-1668 bytes

to make |gatsby| happy.. here's a better comment. :P

AjK’s picture

AjK commented
Status: Needs review » Reviewed & tested by the community

Now Zen's happy with the comment and I'm happy the issue is resolved (works for me a treat)... RTBC :)

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new autocomplete_js.patch-2694 bytes

ok.. a valid point was made.. we need to check .value.length not just .value

Zen’s picture

Zen commented

New patch checked and confirmed to be working. Still RTBC.

-K

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

FWIW, I'm still not able to repeat the problem with Fx2.0

dvessel’s picture

dvessel commented

The same problem appears with Safari 2.0.4.. Bizarre how similar the problem gets reproduced. -same as screen shot from #10.

The patch fixes it though.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Reviewed & tested by the community » Fixed

Tested, confirmed with Steven, and Committed to HEAD.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)