Hi,
I found this module very useful, but I need the fee to be calculated also with shipping costs.
Anyone could give me a hint where to look at?

I patched the code to do what I need, but I'm not completely done: at the checkout page, I was able to make the fee update (also with shipping cost) when switching payments method, but not when switching shipping costs.

Thanks!

CommentFileSizeAuthor
#3 uc_pma-864726-apply_to_shipping.patch1.57 KBxurizaemon

Comments

tchurch’s picture

tchurch commented

bump. also interested in this.

khalemi’s picture

khalemi commented

im also interested. however, the maintainer seems to abandon this module.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Version: 6.x-1.0 » 6.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new uc_pma-864726-apply_to_shipping.patch1.57 KB

optionally apply to shipping also - you need to check the box on the payment methods page

patch tested and committed to 7.x-1.x, applies cleanly to 6.x-1.x but untested and wants review please

wondering what other types of line item might want considering for uc_pma

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Title: calculate fee considering also shipping costs » Optionally apply uc_pma adjustments also to non-product line items (eg shipping)
Assigned: Unassigned » xurizaemon

#841348: pma + tax module is about support for adjusting tax in uc_pma. I'm no accountant, but guess this really depends on whether the tax rules in the area of restriction apply to the sale or to the product? So I'm not actually sure if tax should be handled alongside other non-product line items.

Adding support for other line item types is trivial - we need only to add the value of $order->line_items[n]['type'] to the array in uc_pma_form_alter(). So if you have a type which isn't supported (right now, anything that's not shipping), just ask.