This is a resubmitted issue. See http://drupal.org/node/469590 for the full details.

In the core openid Drupal module (modules/openid/openid.inc), the functions _openid_link_href and _openid_meta_httpequiv perform simple parsing of HTML in order to locate openid provider information; these calls contain regular expressions which depend on the order of the attributes for link and meta tags, respectively.

This breaks, for one, compatibility with Community-ID (http://source.keyboard-monkeys.org/projects/show/communityid), which outputs it's link tags with the "rel" attribute _following_ the "href" attribute - which is valid HTML, but gets missed by the existing parser code.

I resubmitted this issue for the 6.x because the solution should be patched in both 6.x and 7.x and the current issue only applies to the latter and requires a different solution there. Also, the patch submitted will never pass testing if checked against 7.x cvs.

CommentFileSizeAuthor
openid-link-meta-parsing-6.x.patch2.27 KBbasvredeling

Comments

Status: Needs review » Needs work

The last submitted patch, openid-link-meta-parsing-6.x.patch, failed testing.

hefox’s picture

hefox commented
Status: Needs work » Closed (duplicate)

This is a duplicate of the original issue, as far as I can tell. patches get fixed in 7 then backported to 6 using the central issue.

Slydder’s picture

Slydder commented

Community ID is now available here: http://www.itadmins.net/archives/category/itadminsprojects/community-id