Closed (fixed)
Project:
Node Relationships
Version:
6.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
26 Jul 2010 at 18:17 UTC
Updated:
14 Jun 2011 at 14:45 UTC
Jump to comment: Most recent file
Comments
Comment #1
DeeLay commentedattached patch.
I don't particularly like changing the weights of the existing admin_theme_settings form elements, but if I just add the form element to the $form array it appears below the submit and reset buttons, and I couldn't find a better way to make it display correctly.
Comment #2
markus_petrux commentedGood idea! :)
Committed a slight variation of your patch. Please note that I have also changed the variable name, the place where it is applied (now in hook_init) and also added code to delete the variable when the module is uninstalled. Oh, and also changed the way the buttons of the settings form are moved to the bottom, now using a method that may work better when other modules alter that form.
http://drupal.org/cvs?commit=398154
http://drupal.org/cvs?commit=398178 (second patch to add missing cond. in hook_init, sorry)
It should be available with the next dev snapshot, and it will be there in the next release. Thanks!
Comment #3
vincenzo commentedDespite yesterday I was among the supporters of DeeLay's change, I now think there is no need for an extra variable.
The module just needs to be consistent with the theme used by the node-edit forms. Whatever theme (admin or not) a user is using for those forms, they will expect to have the same theme applied in noderelationship's popups.
Therefore, noderelationships could just check against the variable 'node_admin_theme', rather than introduce a new one, which might actually introduce the risk of further inconsistency (users will be deliberately able to use two different themes for node-edit forms and noderealationships popups).
Cheers,
Vincenzo
Comment #4
DeeLay commentedhey,
Thanks for applying this so quickly, took the latest code from CVS and it works fine.
Dom
Comment #6
HelloStephanie commentedJust incase you are looking to enable this like I was after applying the 6.x-1.x-dev -- you can enable the admin theme for Search and Reference by going to admin/settings/admin/theme and checking the box that says "Use administration theme for Node Relationships pages"