Closed (outdated)
Project:
Masquerade
Version:
6.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
27 Jul 2010 at 05:34 UTC
Updated:
14 Oct 2019 at 13:18 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
realityloop commentedPatch attached
Comment #2
deekayen commentedFirst, don't abbreviate variables with this module or any other. I thought at first you were checking to see if the site was defaulting to English before deciding whether or not to display a search box.
Since there are only two options, I'd think you could use 0 or 1. The variable itself isn't re-purposed anywhere else, so make it describe what it does, "masquerade_block_search_visibility".
I personally think radio buttons would be better here. Do you have some plans for other options in this box or a reason to need to select more than one?
You tried to stab a kitten with your patch by changing an unrelated string, which would affect translations which have already been submitted. That's a separate issue so the translation maintainers can be notified.
Comment #3
realityloop commentedThanks for the feedback, revised patch attached.
Comment #4
realityloop commentedLast patch didn't include uninstall for added variable, please test this one instead.
Comment #5
avpadernoI am closing this feature request, as Drupal 6 is no longer supported. Please re-open it if you would like the feature implemented in the Drupal 7 or 8 version of the module.