This is both the bug report and the fix.

The bug is that once a group changes the setting from to any other available role, the role can only be changed to another role but not back to (just doesn't save it). This was caused by a problem in the SQL update. As my programming student told me:

empty($arg) also returns true for the argument 0, so the default value (0) cannot be set again

It's an old bug that existed already in 4.0-dev, and we found it during the upgrade. See the attached patch for the solution implemented in our project :) Thx.

CommentFileSizeAuthor
#1 og_user_roles-HEAD.default-group-role.1.patch1.44 KBsun
default_default_role.patch1.59 KBitsnotme

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed
StatusFileSize
new og_user_roles-HEAD.default-group-role.1.patch1.44 KB

Thanks for reporting, reviewing, and testing! Committed.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

+++ og_user_roles.module	(Revision 471)
@@ -444,17 +444,22 @@
     case 'insert':
-      if (!empty($node->og_user_roles_default_role) && og_is_group_type($node->type)) {
+      if (isset($node->og_user_roles_default_role) && og_is_group_type($node->type)) {
         db_query("INSERT INTO {og_users_roles_group} (gid, default_role) VALUES (%d, %d)", $node->nid, $node->og_user_roles_default_role);

...which means !empty() is correct for the insert case, as we don't want to insert 0.

Powered by Dreditor.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.