Here is an untested patch to get you started in migrating the module to current CVS HEAD.

Comments

TDobes’s picture

Assigned: Unassigned » TDobes
StatusFileSize
new13.79 KB

Here is a tested patch which updates quotes.module to work with the latest menu system changes. It also takes advantage of tabs on the quotes admin page. (use of tabs is nearly identical to that of path.module... an "add" tab and a "quotes" tab, which is the overview page)

Other changes include removal of a bunch of redundant user_access calls (the menu system takes care of this for us) and use of drupal_set_message instead of manually-outputted error/status messages. I also fixed a bug which would display a blank page after importing quotes instead of the "add" form with the appropriate error messages.

TDobes’s picture

StatusFileSize
new13.87 KB

The way tabs are implemented in the menu system has changed slightly, so here's an updated patch. I posted my first patch almost 2 weeks ago... Is any progress being made on this?

jhriggs’s picture

I have been working on updating the module to HEAD myself and have used bits and pieces from both your and JonBob's patches. I try not to do too much work on any of my modules too long before a code freeze, though, because it's like trying to hit a moving target. I would much rather update everything once instead of several times. When the changes have slowed and the dust has settled a bit, I will get everything committed. Thanks for your help! :)

Dehumanizer’s picture

Drupal 4.5 is out. I'm just waiting for this module to be updated to upgrade my site, as I'd never have it without random quotes. :)

red_eye’s picture

I tried Tdobes patch and it worked for the first add, now however I cant access Administer/quotes it tells me I dont have permission, I can access administer/settings/quotes however.

jhriggs’s picture

I am in the process of a complete rewrite of the quotes.module code. Please hang in there for a few more days. I think it will be worth it.

red_eye’s picture

Thanks, my 39,573 quotes await your update :)

jhriggs’s picture

WHOA! Now that would be some test case! Would you mind sending me a dump of your quotes_quotes table so that I can do some scalability and upgrade testing? My e-mail address is in the CREDITS file.

red_eye’s picture

To make things a little easier I have posted it on my site at http://www.patentlystupid.com/node/45 since there may be others who would like the file. I'm on dialup so emailing it multiple times would be a killer.

jhriggs’s picture

Assigned: TDobes » jhriggs

This is implemented in 4.5r1/2004111100.

An upgrade path is provided. Unfortunately, only 1000 existing quotes are imported at a time, so with over 39000 quotes, you have 40 import submissions to do. :-( I think it's worth it, though!

Anonymous’s picture