Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.
I switched out the node.tpl from Mothership for the one from Basic as a better place to start. So the above patch doesn't work any more. But I stole the ideas from it and worked them into node.tpl. I'll commit what I have in a little while.
I did commit a total rewrite of node.tpl.php. Take a look, and see what you think.
This is half-baked:
<?php if ($submitted): ?>
<small class="submitted"><?php print $submitted; ?></small>
<small>Submitted by <?php print $name; ?> on <pubdate><?php print $date; ?></pubdate></small>
<?php endif; ?>
Here's the deal. $submitted has XHTML that we want to override. Ideally we would wrap $date in <pubdate>. And maybe $name in something too. But the second line above is not the way to do it. If nothing else, the words need to be wrapped in t(). But even then, that's not ideal.
So I'm thinking this is a new issue for HTML5 Tools. ?? But I've run out of gas. Too tired to figure this piece out right now.....
Ok — about $submitted.... I'm simplifying the code so that the author name and date is not printed twice. I opened an issue on the HTML5 Tools issue queue about what I think needs to happen in our module to override $submitted #884138: Override $submitted, adding <pubdate>.
Getting into this review! Got really excited about HTML5 & CSS3 in DrupalCon Copenhagen. Now crawling into "Introducing HTML5" and reviewing this stuff.
Anything else besides the tpl -files that require attention?
There's a lot to do — for both themers and module developers. For one, I think we need to redo node.tpl.php based on the advice Jeremy Keith gave in his keynote at DrupalCon CPH. (Which is here: http://drupalradar.com/video-jeremy-keith-keynote-session).
The best place to start is to setup a Drupal 6 site with HTML5 Tools and Base, and look at the markup. What could be better? Which thing is generating it? And then go work on changing that.
Comments
Comment #1
tim.plunkettThis one is all mine. Unless someone else wants to help.
Comment #2
tim.plunkettChanged wrapper to article, added in header and footer. First effort.
Comment #3
jensimmons commentedI switched out the node.tpl from Mothership for the one from Basic as a better place to start. So the above patch doesn't work any more. But I stole the ideas from it and worked them into node.tpl. I'll commit what I have in a little while.
Comment #4
jensimmons commentedI did commit a total rewrite of node.tpl.php. Take a look, and see what you think.
This is half-baked:
Here's the deal. $submitted has XHTML that we want to override. Ideally we would wrap $date in
<pubdate>. And maybe $name in something too. But the second line above is not the way to do it. If nothing else, the words need to be wrapped in t(). But even then, that's not ideal.So I'm thinking this is a new issue for HTML5 Tools. ?? But I've run out of gas. Too tired to figure this piece out right now.....
Comment #5
jensimmons commentedOk — about $submitted.... I'm simplifying the code so that the author name and date is not printed twice. I opened an issue on the HTML5 Tools issue queue about what I think needs to happen in our module to override $submitted #884138: Override $submitted, adding <pubdate>.
Meanwhile, $node is good to go. Committed this: http://drupal.org/cvs?commit=407886
Comment #6
jensimmons commentedActually, this is needs review. You aren't reviewing a patch, review the code that's already committed. The patch in #2 is now out of date.
Comment #7
afox commentedGetting into this review! Got really excited about HTML5 & CSS3 in DrupalCon Copenhagen. Now crawling into "Introducing HTML5" and reviewing this stuff.
Anything else besides the tpl -files that require attention?
Comment #8
jensimmons commentedHi repolainen!
There's a lot to do — for both themers and module developers. For one, I think we need to redo node.tpl.php based on the advice Jeremy Keith gave in his keynote at DrupalCon CPH. (Which is here: http://drupalradar.com/video-jeremy-keith-keynote-session).
The best place to start is to setup a Drupal 6 site with HTML5 Tools and Base, and look at the markup. What could be better? Which thing is generating it? And then go work on changing that.
Comment #9
tim.plunkettComment #10
jensimmons commentedWell, I think in general, this file is done. If you see specific details to alter, open up a new issue.