Posted by q0rban on July 28, 2010 at 1:02pm
3 followers
| Project: | Workflow |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Workflows and Workflow States should have machine names. This is step one in prepping for exportability.
Comments
#1
@see #558378: Make workflows exportable (with features)
#2
Assigning to me, gonna start working on this now.
#3
Wow. This is an insane patch, and it really only touches workflows and workflow_states. Still need to work on spreading the love to the other tables. My testing shows everything working at this point though.
You'll notice that the updates start at 6200, b/c I'm basically assuming this calls for a new major branch.
Other things that need updating are translations.
Whomever reviews this patch, I do not envy you.
#4
Also, I'd like to deprecate some tokens. workflow-name doesn't seem to be a good idea for a token name anymore.
#5
There is a new 2.x branch of Workflow that will focus on implementing this as a step 1 for exportability. http://drupal.org/node/893230
#6
Committed: http://drupal.org/cvs?commit=413152
#7
#8
Automatically closed -- issue fixed for 2 weeks with no activity.
#9
Machine names do not work in 2.x branch. I just tried adding a new workflow, and even though I got label and machine name on the form itself, when I tried to save the new workflow:
1. I was redirected to: admin/build/workflow/edit/op_basic_publishing_workflow/states ( should probably have numeric ID in there, not the machine name)
2. Got a Page not Found error and a message "The workflow Basic Publishing Workflow was created. You should now add states to your workflow."
3. When I went back to the workflows page - there was no workflow that had been created.
I need exportability in order to be able to use this module, hence I am trying to fix these errors in the 2.x branch today/tomorrow + add CTools exportability code and submit a patch to 2.x branch.
#10
Irakli, can you find me in IRC please, so I can sync up with you on the current state? Thanks.
#11
Also, machine names are working, regardless of the fact that the 2 branch is completely unstable, so I'm closing this issue. :)
#12
Automatically closed -- issue fixed for 2 weeks with no activity.