Closed (fixed)
Project:
Drupal for Facebook
Version:
6.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
28 Jul 2010 at 14:01 UTC
Updated:
20 Jan 2011 at 23:10 UTC
Jump to comment: Most recent file
Comments
Comment #1
Dave Cohen commentedI'm not sure what's best, trying to keep up with everything facebook adds, or adding some option to manually type the names of the permissions.
Comment #2
Anclywen commentedif facebook changes it's mind as often as i think it does, manually typed names is great idea.
On the second thought, list of declared permissions is very practical, because you don't have to use facebook's permissions site all the time, to check only name of needed permission.
Maybe we should use both solutions:
a) Manually typed names of permissions - so we don't have to trying keep up with fb all the time (only from time to time :) )
b) List of permissions (on date xx/xx/xxxx)
Comment #3
Dave Cohen commentedChanging to 3.x, since this change is unlikely to make it into 2.x
Right now if you're willing to implement a hook in your own module, you can do something like this...
Comment #4
Anclywen commentedChanges:
1. Updated list of Facebook Permissions (more than 60 permissions)
2. Changed method of display permissions from regular form to analogous to permissions' table (for the sake of usability)
3. Moved permission list to new file and applying some CSS :)
4. (incidentally) Get rid of PHP warning in #865614: Invalid argument supplied for foreach() in /var/www/beta/sites/all/modules/fb/contrib/fb_permission.module on line 56.
For adding new permissions, imho using the hook_fb_required_perms_alter() is the most "clean" solution
Please, review and give feedback
Comment #5
gateway69 commentedDo you have this set up to save any extended permissions the users auths saved to the profile? For example home town is a permission.. Guess we could extend the profile with various fields and populate them when permissions are granted since now you can store fb data on your one server
Comment #6
Anclywen commentedNot quite understand what you mean.
If you are proposing the creation of the fields that will store user data, I am afraid that this is against the Facebook terms of service (FB TOS - section 9.3), and here is the opinion of Dave Cohen about this subject #709468-1: RealName integration. You can only cache user data to improve your application’s user experience.
Comment #7
escore commentedAs gateway69 said, Facebook no longer prohibits the storage of user data as long as the user consents and you're clear about how you use that data. At least that's how I understand the current terms. Perhaps FB changes the terms as often as they change their other stuff (btw, section 9.3 now reads "You will not give us information that you independently collect from a user or a user's content without that user's consent."). The change in terms could open up for new features in other parts of DFF as well, not just fb_permissions.
Comment #8
Anclywen commentedThis changes the situation.
Sorry, it seems that I have read the FB policies again, and this very carefully:)
At first glance, everything is based on the own privacy policy page
However, I propose to open a new issue about this subject (and leave this issue to determine whether the patch is suitable or not)
Comment #9
Dave Cohen commentedThanks Anclywen for the patch. I will review when I have a moment.
I agree that the idea of saving data from facebook into drupal user profile (or better, syncing the data) should be discussed in another issue.
Comment #10
gateway69 commentedThanks for the patch, I did it another way but ill use yours instead :) btw I did create a separate issue/request for the profile fields..
http://drupal.org/node/878282
Comment #11
gateway69 commentedI had to reinstall with the latest fb build, the patch seems to go kaboom :(
ST
Comment #12
Anclywen commentedComment #13
ckngInstead of maintaining the label and description manually, it may be easier to use permissions_info to retrieve those information. So we only need to keep track of permission names.
Comment #14
Dave Cohen commentedI'm not sure what you mean. What's permissions_info?
Comment #15
ckngThis http://developers.facebook.com/docs/reference/fql/permissions_info, if not maintaining the list will be a headache
Comment #16
Dave Cohen commentedThanks, I agree it should use that table. Ideally it would learn which permissions are available via FQL, but I don't see any way to query that.
Comment #17
Dave Cohen commentedChecked in a change. Next release will query the entire list of permissions.