hook_nodeapi now uses its third parameter when doing "validate", but this was not documented.

Since this third parameter now has two distinct semantics, the patch not only documents the fact but changes the parameter names to the convention used in node_invoke_nodeapi ($a3, $a4) instead of ($teaser, $page), which is specific to the "view" operation.

CommentFileSizeAuthor
core.php_1.patch1.31 KBfgm

Comments

fgm’s picture

Assigned: Unassigned » fgm
Status: Needs review » Fixed

Committed directly, under chx's suggestion.

webchick’s picture

Status: Fixed » Needs work

Ugh. $a3 and $a4? Is there not a more descriptive name for these we could pick?

webchick’s picture

Status: Needs work » Fixed

Well. Fair enough. They are indeed called that in node_invoke_nodeapi.

No idea how that made it through but there you go. :P

fgm’s picture

The name change for the a3/a4 parameters was applied on 28/04/04 in version 1.350 of node.module by Jonbob, committed by Dries, when the fourth parameter was added to hook_nodeapi :

http://cvs.drupal.org/viewcvs/drupal/drupal/modules/node/node.module?r1=...

Anonymous’s picture

Status: Fixed » Closed (fixed)