Closed (fixed)
Project:
Drupal core
Version:
4.7.3
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
29 Sep 2006 at 20:51 UTC
Updated:
14 Oct 2006 at 07:45 UTC
hook_nodeapi now uses its third parameter when doing "validate", but this was not documented.
Since this third parameter now has two distinct semantics, the patch not only documents the fact but changes the parameter names to the convention used in node_invoke_nodeapi ($a3, $a4) instead of ($teaser, $page), which is specific to the "view" operation.
| Comment | File | Size | Author |
|---|---|---|---|
| core.php_1.patch | 1.31 KB | fgm |
Comments
Comment #1
fgmCommitted directly, under chx's suggestion.
Comment #2
webchickUgh. $a3 and $a4? Is there not a more descriptive name for these we could pick?
Comment #3
webchickWell. Fair enough. They are indeed called that in node_invoke_nodeapi.
No idea how that made it through but there you go. :P
Comment #4
fgmThe name change for the a3/a4 parameters was applied on 28/04/04 in version 1.350 of node.module by Jonbob, committed by Dries, when the fourth parameter was added to hook_nodeapi :
http://cvs.drupal.org/viewcvs/drupal/drupal/modules/node/node.module?r1=...
Comment #5
(not verified) commented