A "file cannot be found" message [#867304]

Actually if the path to the file that's going to be imported, is not pointing to any file, this message is used:
"The selected file could not be saved. The file is not a known image format."

For better troubleshooting i think, the message should sound more like this one:
"The selected file could not be found."

Comment	File	Size	Author
#3	filefield.migrate.inc_message.patch	2.41 KB	wapnik

Comments

Comment #1

wapnik commented 28 July 2010 at 15:18

Project:	Migrate Extras	» FileField
Version:	6.x-1.x-dev	» 6.x-3.x-dev
Component:	Filefield	» Code

I see now this is more an issue for filefield and its field_file_save_file function.

Comment #2

quicksketch

he/him

commented 28 July 2010 at 17:16

Project:	FileField	» Migrate Extras
Version:	6.x-3.x-dev	» 6.x-1.x-dev
Component:	Code	» Filefield

This message is typically only shown when a user tries to upload a file that is not a valid image, such as if they upload a BMP file or something. The message is accurate in the usual situations where you would encounter it. The message that the file doesn't exist would be extremely rare in a situation where a user is uploading a new file (since it obviously exists if they just uploaded it).

I'd probably suggest that Migrate Extras check that the file exists before trying to save it (however it does that).

Comment #3

wapnik commented 29 July 2010 at 12:05

Status:

Active

» Needs review

Status	File	Size
new	filefield.migrate.inc_message.patch	2.41 KB

Yes sounds logical.

However Migrate Extras does not check if the file exists, it relies on the field_file_save_file function to do the validations. So here is a patch with my implementation.