I might be dumber than the average user, since no one else has reported this, but it just took me 15 minutes to figure out that you should only click the Attach button when you are uploading a new image, not when you are choosing one to attach from the list. I was thrown off because the field set is labeled "Attached images", so I thought that "attach" always meant attach regardless of the source of the image. Maybe the button should be labeled "Upload".
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | 867386-13.image_.attach-button-followup.patch | 1.46 KB | joachim |
| #3 | image-DRUPAL-6--1.attach-button.3.patch | 864 bytes | sun |
Comments
Comment #1
sunMakes sense. Normally, string changes should be avoided in stable releases, but since the string "Upload" is likely to exist + be translated already, this change shouldn't do any harm.
Comment #2
joachim commented> you should only click the Attach button when you are uploading a new image, not when you are choosing one to attach from the list.
I've seen other bug reports from people doing that.
Comment #3
sunComment #5
joachim commentedHmm do any of our tests click the 'Attach' button?
Comment #6
xenophyle commentedWow, this is getting a really quick response! I appreciate it.
Comment #7
joachim commented#3: image-DRUPAL-6--1.attach-button.3.patch queued for re-testing.
Comment #9
joachim commentedThis seems to be failing for total WTF reasons to do with the testing rig.
I can't see anything in our image attach tests that tries to click the 'Attach' button, so RTBC.
Comment #10
joachim commentedCommitted.
#867386 by sun: Changed image attach form's 'Attach' button to 'Upload'.
Comment #11
joachim commentedWe missed this:
$uploading_new_image = ($form_state['clicked_button']['#value'] == t('Attach'));
Comment #12
joachim commentednow a bug.
Comment #13
joachim commentedCommitted this patch.
#867386 by joachim: (Followup) Fixed remaining checks for 'Attach' button.