Shouldn't line 227 be

    $('#modal-content input[type="submit"]:not(.ctools-use-modal-processed), #modal-content button:not(.ctools-use-modal-processed)', context)

it now is

    $('#modal-content input[type="submit"]:not(.ctools-use-modal-processed), button:not(.ctools-use-modal-processed)', context)

Because of how it now is. When i have a button and a link on the same page, and i give the link the class ctools-use-modal. The buttons on that page get ctools-use-modal-processed.

Is this an bug or am i missing or doming something wrong?

Comments

merlinofchaos’s picture

merlinofchaos commented

Er. Yes, #modal-content should indeed be prefixing the 'button'. It's probably a fairly obscure bug because 'button' is fairly rarely used.

Michsk’s picture

Michsk commented

that's true, i also basically don't use buttons, but the homebox module does and that's how i spotted this. Other question, do you merlinofchaos take funding for updating / upgrading modules? Or do you know someone who could do so? I am using the modal option of ctools, but i really must say that it has issues. IE8 doesn't have a transparant background. IE7 breaks theming when a form returns with errors. All IE have problems when you open a modal, modal content is rendered and you close it then directly open a new modal. The new modal gets rendered at the bottom right corner of the window and not in the center. And then offcourse there's the implementation of animations and the other options (fluid dimensions).

Michsk’s picture

Michsk commented

and for the above, the dialog api is no option that module is very buggy and seems unmaintained.

merlinofchaos’s picture

merlinofchaos commented

File individual issues about the stuff that isolate the issues and I can look at them.

Michsk’s picture

Michsk commented

ok, i will do.

merlinofchaos’s picture

merlinofchaos commented
Status: Active » Fixed

Ok, fixed the button part of this.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.