Download & Extend
Issues

Files and Images don't work in private filesystem mode

Posted by Damien Tournoud on July 29, 2010 at 2:30am
Project:Drupal core
Version:7.x-dev
Component:file.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

When using a private filesystem, neither files nor images work, because file_get_file_references() is still severely broken.

[#846296] tested part of file_get_file_references(), but not the part where the check is done across all the fields (ie. $field is NULL).

Login or register to post comments

Comments

#1

Posted by Damien Tournoud on July 29, 2010 at 2:31am

This was noted in the original post of [#846296].

#2

Posted by Damien Tournoud on July 29, 2010 at 2:34am
Status:active» needs review

The correct fix is simply, but we need a test of this.

AttachmentSizeStatusTest resultOperations
867928-file-private-downloads-broken.patch905 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 22,196 pass(es).View details

#3

Posted by andypost on July 29, 2010 at 3:34pm
Status:needs review» reviewed & tested by the community

Tested, works!

#4

Posted by Dries on July 30, 2010 at 1:46am
Priority:critical» normal
Status:reviewed & tested by the community» needs work

Committed to CVS HEAD but setting to 'needs work' because we still need a test.

#5

Posted by andypost on July 30, 2010 at 6:53am
Status:needs work» needs review

Extended tests:
- Added check that file downloadable for public scheme
- Added check for changing 'uri_scheme' setting
- Added check for private method download works

AttachmentSizeStatusTest resultOperations
867928-file-tests-d7.patch3.12 KBIdlePASSED: [[SimpleTest]]: [MySQL] 22,479 pass(es).View details

#6

Posted by Damien Tournoud on August 3, 2010 at 8:12am
Status:needs review» reviewed & tested by the community

Looks good!

#7

Posted by int on August 4, 2010 at 6:13am
Status:reviewed & tested by the community» fixed

Commit #402088 by Dries at 04:50
- Patch #867928 by Damien Tournoud, andypost: more tests for file and image handling.

#8

Posted by System Message on August 18, 2010 at 6:20am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here