Data taxonomy currently allows you to relate data entries to taxonomy terms. Data can be related to terms in the specific vocabularies. Currently, the only way to select a vocabulary is by vid (a serial ID). This module should also support selecting a vocabulary by module name, which will provide compatibility with exported vocabularies using the Features module.

Comments

Will White’s picture

Status: Active » Needs work
StatusFileSize
new7.49 KB

This patch alters the data taxonomy settings form to add an option for select vocabularies by module name. It also updates the taxonomy form to recognize these changes.

Will White’s picture

StatusFileSize
new8.4 KB

Minor adjustment to config check in hook_views_data().

Will White’s picture

StatusFileSize
new7.06 KB

New version that updates more code to be compatible.

Will White’s picture

StatusFileSize
new13.54 KB

Sorry, wrong patch!

alex_b’s picture

What's missing here to make this NR? To me this patch looks complete.

Will White’s picture

Status: Needs work » Needs review

You're right.

David Goode’s picture

StatusFileSize
new648 bytes

A patch to apply atop that one that makes the unique-vocab filtering work as expected. The module field in the vocab table is not necessarily unique, so only vocabs that have a unique one should be allowed to be selected via this method (still would be allowed via vid). Previously this functionality was supposed to be there, but in the case of an odd number > 1 of similarly named vocabs it would fail and allow one through.

alex_b’s picture

Issue tags: +6.x-1.0-alpha13

To be released w/ 6.x-1.0-alpha13.

alex_b’s picture

Assigned: Will White » alex_b
StatusFileSize
new13.71 KB

#7 - yikes! when did we start rolling patches for patches? Evil. Rerolling #4 + #7. Reviewing now.

alex_b’s picture

StatusFileSize
new5.32 KB

Looking back at the patches David filed against Feeds to support exportable vocabularies I find that we can also make this patch much more straightforward by simply choosing $vocabulary->module over $vocabulary->vid whenever module name starts with "feature_" - hence is unique.

This boils down the 14k patch to a mere 5k.

Now I feel bad Will because I asked you to go down the vocabulary_module/vocabulary_method road :-/

alex_b’s picture

Title: Enhance data taxonomy to allow selecting vocabularies by module » Support exportable vocabularies
Status: Needs review » Fixed

This is committed now.

alex_b’s picture

Thank you :)

Status: Fixed » Closed (fixed)
Issue tags: -6.x-1.0-alpha13

Automatically closed -- issue fixed for 2 weeks with no activity.