Closed (fixed)
Project:
Data
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
29 Jul 2010 at 17:21 UTC
Updated:
3 Jan 2014 at 01:42 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Will White commentedThis patch alters the data taxonomy settings form to add an option for select vocabularies by module name. It also updates the taxonomy form to recognize these changes.
Comment #2
Will White commentedMinor adjustment to config check in hook_views_data().
Comment #3
Will White commentedNew version that updates more code to be compatible.
Comment #4
Will White commentedSorry, wrong patch!
Comment #5
alex_b commentedWhat's missing here to make this NR? To me this patch looks complete.
Comment #6
Will White commentedYou're right.
Comment #7
David Goode commentedA patch to apply atop that one that makes the unique-vocab filtering work as expected. The module field in the vocab table is not necessarily unique, so only vocabs that have a unique one should be allowed to be selected via this method (still would be allowed via vid). Previously this functionality was supposed to be there, but in the case of an odd number > 1 of similarly named vocabs it would fail and allow one through.
Comment #8
alex_b commentedTo be released w/ 6.x-1.0-alpha13.
Comment #9
alex_b commented#7 - yikes! when did we start rolling patches for patches? Evil. Rerolling #4 + #7. Reviewing now.
Comment #10
alex_b commentedLooking back at the patches David filed against Feeds to support exportable vocabularies I find that we can also make this patch much more straightforward by simply choosing $vocabulary->module over $vocabulary->vid whenever module name starts with "feature_" - hence is unique.
This boils down the 14k patch to a mere 5k.
Now I feel bad Will because I asked you to go down the vocabulary_module/vocabulary_method road :-/
Comment #11
alex_b commentedThis is committed now.
Comment #12
alex_b commentedThank you :)