After not getting any argument fields in the plugin setup for rules_views_executor, I dug in to your code, and found that only Identifiable datatypes where supported as arguments from views to rules. This effectively limits argument types to nodes, users and comments. I found that my brilliant plan failed due to this, and set out to find a solution.
Argument values are already passed to rules_views_executor_execute_ruleset() directly from the views plugin, so the values were already available.
I made some changes to rules_views_executor_execute_ruleset(), and some in the rules_views_executor_plugin_row_ruleset class, but all together nothing major.
I'll try to make some patches for you tomorrow (my cvs foo is a little rusty). Before that I want to ask you why you chose not to implement support for primitive types.
Where there some major problems that I should be aware of?
-Vidar
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | rules_views.module.patch | 1.55 KB | Vidarls |
| #1 | rules_views_executor_plugin_row_ruleset.in_.patch | 2.57 KB | Vidarls |
Comments
Comment #1
Vidarls commentedOk heres patches,
- Vidar
Comment #2
steven jones commentedI don't think that there was a major reason why I didn't implement them, just didn't get around to it. I'll look at the patch tomorrow.
Comment #3
Vidarls commentedGreat, just let me know if you need anything changed.
Comment #4
steven jones commentedSorry, I ran out of time to review this, will try to look this evening.
Comment #5
steven jones commentedPatch looks good, needs a couple of minor cleanups, but I'll do those as I commit.
Comment #6
steven jones commentedCommitted to CVS.
http://drupal.org/cvs?commit=406980
Comment #7
steven jones commentedThis was actually a feature request.