After not getting any argument fields in the plugin setup for rules_views_executor, I dug in to your code, and found that only Identifiable datatypes where supported as arguments from views to rules. This effectively limits argument types to nodes, users and comments. I found that my brilliant plan failed due to this, and set out to find a solution.

Argument values are already passed to rules_views_executor_execute_ruleset() directly from the views plugin, so the values were already available.
I made some changes to rules_views_executor_execute_ruleset(), and some in the rules_views_executor_plugin_row_ruleset class, but all together nothing major.
I'll try to make some patches for you tomorrow (my cvs foo is a little rusty). Before that I want to ask you why you chose not to implement support for primitive types.
Where there some major problems that I should be aware of?

-Vidar

Comments

Vidarls’s picture

Status: Active » Needs review
StatusFileSize
new2.57 KB
new1.55 KB

Ok heres patches,

- Vidar

steven jones’s picture

I don't think that there was a major reason why I didn't implement them, just didn't get around to it. I'll look at the patch tomorrow.

Vidarls’s picture

Great, just let me know if you need anything changed.

steven jones’s picture

Assigned: Unassigned » steven jones

Sorry, I ran out of time to review this, will try to look this evening.

steven jones’s picture

Status: Needs review » Reviewed & tested by the community

Patch looks good, needs a couple of minor cleanups, but I'll do those as I commit.

steven jones’s picture

Status: Reviewed & tested by the community » Fixed
steven jones’s picture

Category: bug » feature

This was actually a feature request.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.