(what a title!)

I originally thought I should file two separate issues, but both of them seem related (as to what needs to be done code-wise). Here's the deal...

part 1. If no 'Default display mode' option is selected, the summary in the 'Comment settings' tab displays this: Read only, , 50 comments per page

...when it should be like so: Read only, 50 comments per page

part 2. When comments are disabled for a node type, this is what is shown: Disabled, Flat list - collapsed, 50 comments per page

...when it should simply be: Disabled

I mean there is no point in displaying the rest of the settings when comments are generally disabled!

PS: I was contemplating whether this should be filed as a bug report (part 1 kinda is) or a feature request, so I ended up filing it as a task ;)

Comments

dave reid’s picture

Category: task » bug

Can you confirm that D7's included veritical tabs do the same thing? I'd consider this a bug.

klonos’s picture

Short answer: nope, part 1 doesn't seem to happen in d7, part 2 kinda still does.

Long(er) answer:

part 1: In d7 the respective 'Comments settings' tab has a few different things than in d6. You see, in d6 the missing part of the displayed summary was caused by the luck of a default selection in the 'Default display mode' radio button set. In d7 this radio button set was changed to a 'Threading' checkbox and this is checked by default (at least for the two built in content types). So, what I see is: Closed, Threading , 50 comments per page. The only minor 'cosmetic' issue I see here is an extra space between the 'Treading' and the comma, but this is really trivial (I might report it anyways, because you never know what minor issues might be hiding behind them).

part 2: The 'Default comment setting' was changed in d7 too. Instead of a 'Disabled'/'Read only'/'Read/Write' radio button set, we now have a 'Hidden'/'Closed'/'Open' drop-down menu. I guess 'Hidden' is the equivalent of 'Disabled', so one gets this: Hidden, Threading , 50 comments per page, that still doesn't make sense.

Edit: I don't know if this was stressed enough, but part1 (empty strings) of the issue should be solved if we made sure that the 'Default display mode' radio button set always has a default value.

klonos’s picture

Title: Do not display empty settings in summary + Do not display rest of (comments) settings in summary if main setting is disabled » Don't display empty settings in summary + Don't display rest of the settings in summary if default setting is set to 'Disabled'

...minor correction of the issue's title.

klonos’s picture

An update on this one too please?