Poor category_menu_delete_item has both a very inefficient function signature and downright wrong documentation.

After doing some research, it seems the documentation has been wrong since revision 1.3, when the second parameter was removed!

Changing the API to be more in line with the mapping stuff: Pass in nid's instead of nodes.

Patch against CVS. 4.7 version shortly.

CommentFileSizeAuthor
#1 category_menu.module-speedup1-4.7.patch2.81 KBbdragon
category_menu.module-speedup1-cvs.patch2.8 KBbdragon

Comments

bdragon’s picture

bdragon commented
StatusFileSize
new category_menu.module-speedup1-4.7.patch2.81 KB

Didn't have any conflicts, so this was faster than expected :-)

Here's the DRUPAL-4-7 version.

TheWhippinpost’s picture

TheWhippinpost commented

When deleting a category, I got an error page citing an, !Illegal offset! which was reported as emanating from line 646 of the category_menu.module.

Removing the above patch (category_menu.module-speedup1-4.7.patch) fixed the error.

HTH