(the issue's title might be ironic, but it is meant to emphasize the problem) I have spotted these:
'Publishing options' during node create
- 'Expiration Date:' field name
In content type 'Workflow settings':
- 'Expiration Date:' field name (should be 'Default expiration date:' btw)
- 'Expiration Date Limit:' field name
- 'Expiration Date Required' checkbox
...might be others as well. Please help spot them and fix them all.
I know, I know... a lot of other modules do this. It is Drupal standard to not capitalize module/theme names except the first letter of the first word though. So it should also be 'Node expire' instead of 'Node Expire'. Drupal capitalization standard:
name (Required)
The displayed name of your module. It should follow the Drupal capitalization standard: only the first letter of the first word is capitalized ("Example module", not "example module" or "Example Module"). Spaces are allowed as the name is used mainly for the display purposes.
Comments
Comment #1
klonos...added a tag to help follow up same issues in other modules.
Comment #2
vikramy commentedFixed in latest dev and in head. If you find more feel free to reopen. Thanks by the way for making me follow standards.
Comment #3
klonosNo problem mate and thanx for fixing it in a snap! We should be thanking you for your time and effort on this module. I will let you know if I find any other bits that need fixing ;)
...BTW, could you take a look at this while you're at it?: #870042: Add the module to a (new) package category (a.k.a. unclutter the default 'Other' category)
Comment #4
klonos...I think you should also fix capitalization of the name in the module's front page too.
Comment #5
vikramy commentedYou mean in README.txt?
Comment #6
klonosYeah some places in the README.txt too, but I was referring to the title in the project's page: http://drupal.org/project/node_expire (it still reads 'Node Expire' instead of 'Node expire')
Comment #8
michelleSee #1346158: Decide on coding standard for capitalization of module names [policy, no patch] and #1430452: Use Proper Name Case for core modules for current information on this policy.
Comment #9
klonos...yep, the standard has changed and it now allows (more likely suggests) Proper Name Case instead of the Sentence case for module/theme names. The Sentence case policy remains for UI text like widget labels for example.
Comment #10
Nafes commented