I'm using WebFM with Organic Groups and so far so good. Exactly what I've wanted since i first started programming in Drupal! I'm very grateful for the excellent development and continued maintenance of this and I will do my best to provide feedback as a user. that said...

This is a minor bug i noticed:
If a Group somehow does NOT have a Root Directory and a user uploads a file with WebFM to that Group, the file is uploaded to the next available Group Root Directory from the list of Groups to which that the user belongs. The file doesn't get uploaded to the WebFM root directory as one might expect.

Steps to Reproduce:
1. Create three groups: "Group A" (no root directory), "Group B" (root directory = group_b), and "Group C" (root directory = group_c).
2. Create a new user and subscribe them to the three groups
2. Have the user upload a file with WebFM into Group A, the file will end up in Group B's root directory.

Please note: i DO NOT have Role Root Directories set up because i want both roles to use the WebFM Root (not sure if this would make a difference).

thanks again for a great module!

Comments

cgmonroe’s picture

cgmonroe commented
Category: bug » feature

Hmm, this one got lost in the clutter....

Thinking this through, IMHO this is actually working as designed. Here is the designed logic:

If someone has permissions set to upload and/or webfm attach files to a content type, they can do it anywhere, because its a role permission.

The "default" webfm file store (e.g role(s) or group(s) root directories) will always be the same for each user, the first one found by the logic in webfm_get_root_dirs() and webfm_get_group_root_dirs() (or the webfm root for admins).

By design, if the user doesn't select a different directory before upload, it will go to the first role/group root directory found.

So, the behavior that you are seeing is by design.

That said, it would be a nice new feature if we could figure out how to have more OG specific rules. So, I'm remarking this as a feature request.

But on the bright side, now that the custom layout patch has been committed, I'm working on "generic" version of a module I call the webfm_og_utils. This supplies some OG specific blocks and a group files page that are "locked" down to the group. The logic that determines if a block or page is displayed already checks for the existence of a group directory.

The core work has been done (since we use it in some of our sites here...) and I've started on the work to make it generic but it's stalled because I'm overloaded with work and life stuff at the moment.

nodecode’s picture

nodecode commented

Hah! I forgot all about this issue, but now you've got me wishing to see webfm_og_utils :)

Thank you for all the great work you do on this module.

spacereactor’s picture

spacereactor commented

that what i looking for my private group users. subscribe