I noticed that the Flexible layout is producing some CSS that causes columns to shift outside the $content area. Pictured below is a simple 3-column flexible layout with a fixed left column, fixed right column and a fluid middle column. The left/right columns have a negative margin equal to its width as set the Panels UI. These should be set to 0, with both margins being applied to the fluid column.
This patch adjusts the margin/padding settings in flexible.inc to keep it all contained within the canvas.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 869766-all-left-fixed-flexible-broken.patch | 2.45 KB | merlinofchaos |
| #9 | exported flexible layout.txt | 3.78 KB | franzkewd |
| #7 | exported flexible layout.txt | 4.26 KB | franzkewd |
| #3 | panel_page_working.txt | 8.08 KB | mirakolous |
| #3 | panel_page_not_working.txt | 9.07 KB | mirakolous |
Comments
Comment #1
merlinofchaos commentedCan you export a panel that demonstrates the problems you're seeing? I don't want to fix a problem I can't perceive.
Comment #2
ruplHere you go, the panel export is attached along with another screenshot.
Comment #3
mirakolous commentedI have the same problem, but the patch did not work for me. I cloned the same panel page several times. Some of these cloned pages worked, and some had the margin issue. I have attached an exported panel for both a working and non-working page.
Comment #4
merlinofchaos commentedYou would need to clear cache for the patch to have any effect, as the CSS is cached.
Comment #5
merlinofchaos commentedI confirm with the export in #3 that a cache clear does indeed fix the problem with that export. Committed this fix.
Comment #7
franzkewd commentedI have to re open this since this patch (applied on latest 6.3.dev Sept 11 built) throws my panels off the screen to the left.
My panels was working fine until the previous 6.3.dev built. I fixed my panels on latest 6.3.dev Sept 11 by applying this patch in the opposite way.
Comment #8
merlinofchaos commentedUnfortunately this export has WYSIWYG markup in it, which corrupts the code. Silly wysiwyg. Can you disable wysiwyg on the export, and cut & paste that one instead?
Comment #9
franzkewd commentedMy bad not re-checking the attachement.
This is the clean one.
Comment #10
merlinofchaos commentedTry this.
Comment #11
franzkewd commentedApplied patch #10 on latest built 6.3.dev magically works.
Cheers
Comment #12
merlinofchaos commentedGreat. Committed to -dev!
Comment #13
pvasener commentedI think this patch causes a problem because, since I upgraded to panels 3.8, the css is no longer added for my flexible panels when I view the nodes. It's ok if I preview them though. To confirm the bug, I replaced flexible.inc with the 3.7 version and everything went back to normal.
Comment #14
merlinofchaos commentedPlease file a new issue and link to this one.
Also 'needs work' is a really bad status to use, as items in 'needs work' tend to get ignored except by the people working on them. Which in this case would be nobody.