Notice: Undefined variable: user_role_alias in user_build_filter_query [#870196]

    *  Notice: Undefined variable: user_role_alias in user_build_filter_query() (line 3206 of F:\xampplite\htdocs\drupal7\modules\user\user.module).
    * PDOException: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '= '3')' at line 2: SELECT COUNT(u.uid) AS expression FROM {users} u INNER JOIN {users_roles} ur ON ur.uid = u.uid WHERE (u.uid <> :db_condition_placeholder_0) AND (.rid = :db_condition_placeholder_1) ; Array ( [:db_condition_placeholder_0] => 0 [:db_condition_placeholder_1] => 3 ) in PagerDefault->execute() (line 86 of F:\xampplite\htdocs\drupal7\includes\pager.inc).

Comment	File	Size	Author
#10	870196.patch	3.28 KB	ericduran
#6	user-admin-filter-870196.patch	1.85 KB	mitchmac
#1	drupal_870196.patch	708 bytes	tobiasb

Comments

Comment #1

tobiasb

German

Berlin

commented 31 July 2010 at 10:46

Status	File	Size
new	drupal_870196.patch	708 bytes

Comment #2

Stevel commented 31 July 2010 at 11:55

Could you describe the steps I need to take to reproduce this bug? That helps a lot for testing the patch.

Comment #3

damien tournoud commented 31 July 2010 at 11:59

Issue tags:

+Needs tests

-      $user_roles_alias = $query->join('users_roles', 'ur', '%alias.uid = u.uid');
+      $user_role_alias = $query->join('users_roles', 'ur', '%alias.uid = u.uid');
       $query->condition($user_role_alias . '.rid' , $value);

The name of the table is 'users_roles', so the name of the variable should be $users_roles_alias.

Also, this needs tests.

Comment #4

damien tournoud commented 31 July 2010 at 11:59

Status:

Needs review

» Needs work

Comment #5

tobiasb

German

Berlin

commented 31 July 2010 at 13:14

@Stevel sure. go to people (admin/people), then filter by role (administrator).

Status	File	Size
new	user-admin-filter-870196.patch	1.85 KB

Comment #7

infojunkie

Vancouver

commented 31 July 2010 at 23:15

Status:

Needs review

» Reviewed & tested by the community

Reviewed and applied patch #6: success. Also undid patch for user.module and applied new test: failure.

I think this looks good but ideally, UserAdminTestCase would be refactored a bit. This patch sort of slaps a test case onto the existing class without looking at what is there. I think UserAdminTestCase could be tidied up a little.