it says $parameters but it expects a variable number arguments, delete $parameters from the function header because it's not used anyways and add ... to the doxygen.

CommentFileSizeAuthor
#5 870584_2.patch1.41 KBsender
#3 870584.patch1.41 KBsender

Comments

jhodgdon’s picture

Sounds like a good plan, and indeed a good project for a novice doc contributor.

sender’s picture

Assigned: Unassigned » sender
sender’s picture

Status: Active » Needs review
StatusFileSize
new1.41 KB

Inspiration for syntax and wording from drupal_get_form() and module_invoke().

jhodgdon’s picture

Status: Needs review » Needs work

Close!

a) Little-known English grammar point (even by native speakers): "which" in cases like "Wrapper for register_shutdown_function() which catches thrown exceptions" needs to be changed to "that".

b) Needs a blank line between the last @param and the @return:

+ * @param ...
+ *   Additional arguments to pass to the shutdown function.
  * @return
sender’s picture

Status: Needs work » Needs review
StatusFileSize
new1.41 KB

a) Interesting. Explanation on 'that' vs. 'which': http://www.worldwidewords.org/articles/which.htm

b) Fixed for this function. A quick regex on HEAD throws 309 of these.. new issue?

Status: Needs review » Needs work

The last submitted patch, 870584_2.patch, failed testing.

sender’s picture

In the dark about the test failure, it seems to apply to HEAD without a problem.. anyone?

berdir’s picture

Status: Needs work » Needs review

#5: 870584_2.patch queued for re-testing.

jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

Yes, fixing all the missing newlines in Drupal core between @param and @return (and also after @return if there are @see etc.) would be a separate issue. Actually aspilicious started fixing these and webchick asked that we stop for now because the patches were getting in the way of more significant ones (trying to get D7 out of the door, etc.). See http://drupal.org/node/855184 for one example.

Anyway, all of that aside, this patch looks fine, thanks!

dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.