Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
documentation
Priority:
Normal
Category:
Bug report
Assigned:
Issue tags:
Reporter:
Created:
1 Aug 2010 at 02:17 UTC
Updated:
3 Jan 2014 at 01:42 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jhodgdonSounds like a good plan, and indeed a good project for a novice doc contributor.
Comment #2
sender commentedComment #3
sender commentedInspiration for syntax and wording from drupal_get_form() and module_invoke().
Comment #4
jhodgdonClose!
a) Little-known English grammar point (even by native speakers): "which" in cases like "Wrapper for register_shutdown_function() which catches thrown exceptions" needs to be changed to "that".
b) Needs a blank line between the last @param and the @return:
Comment #5
sender commenteda) Interesting. Explanation on 'that' vs. 'which': http://www.worldwidewords.org/articles/which.htm
b) Fixed for this function. A quick regex on HEAD throws 309 of these.. new issue?
Comment #7
sender commentedIn the dark about the test failure, it seems to apply to HEAD without a problem.. anyone?
Comment #8
berdir#5: 870584_2.patch queued for re-testing.
Comment #9
jhodgdonYes, fixing all the missing newlines in Drupal core between @param and @return (and also after @return if there are @see etc.) would be a separate issue. Actually aspilicious started fixing these and webchick asked that we stop for now because the patches were getting in the way of more significant ones (trying to get D7 out of the door, etc.). See http://drupal.org/node/855184 for one example.
Anyway, all of that aside, this patch looks fine, thanks!
Comment #10
dries commentedCommitted to CVS HEAD. Thanks.