For some reasons, the l() function throws a fatal error when the $options parameter is not an array. No matter the cause, one should never assume the type of a variable. Specially if a non expected type can bring the web site down.

I am submitting this patch to use and empty array if the provided $options parameter is not an array.

Cheers

Asiby

CommentFileSizeAuthor
#6 870616_8.patch402 byteslambic
#6 870616_7.patch402 byteslambic
#6 870616_6.patch392 byteslambic
common.inc_.patch370 bytesasiby

Comments

asiby’s picture

asiby commented
Assigned: asiby » Unassigned
dddave’s picture

dddave commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, common.inc_.patch, failed testing.

Mikey Bunny’s picture

Mikey Bunny commented

I have the same problem. I have applied the patch and it works fine for me and fixes the issue. Please can we have more details as to why this failed testing? Thanks.

dpearcefl’s picture

dpearcefl commented

if you look at "view details" on the patch, you will see "Ensure the patch applies to the tip of the chosen the code-base" meaning it wasn't against the latest 6.x-dev codebase.

Also make sure the patch file name is compliant. http://drupal.org/node/1054616

lambic’s picture

lambic commented
Version: 6.17 » 8.x-dev
Status: Needs work » Needs review
StatusFileSize
new 870616_6.patch392 bytes
new 870616_7.patch402 bytes
new 870616_8.patch402 bytes

Here are 3 patches for 8.x, 7.x and 6.x

marcingy’s picture

marcingy commented
Status: Needs review » Closed (won't fix)

This is not critical and to be honest is really won't fix, drupal does not baby sit broken code. If something dies raise an issue with the contrib module or developer. And on a second point a silent conversion that provides success does no one any good.