I am starting development on a Drupal 7 version of the module. I will post updates to this thread.

Thanks
Robert

CommentFileSizeAuthor
#13 870830-d7-comment-closer.patch39 KBagentrickard
#12 870830-d7-comment-closer.patch38.3 KBagentrickard
#11 870830-d7-comment-closer.patch33.13 KBagentrickard
#10 870830-d7-comment-closer.patch30.29 KBagentrickard

Comments

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

With the updates to 6.x-1.x-dev, you may need to start again. :-(

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Title: Create Druipal 7 Version of this project. » Create Drupal 7 Version of this project.

There is not much left of the module as it was a week ago.

rmiddle’s picture

rmiddle commented

It is a small module not like there is that much to upgrade.

Thanks
Robert

tonycpsu’s picture

tonycpsu commented

Subscribing

threading_signals’s picture

threading_signals commented

Is the d7 port project abandoned?

As of June 28, 2011: "Project not supported: This project is no longer supported, and is no longer available for download. Disabling everything included by this project is strongly recommended!"

rmiddle’s picture

rmiddle commented

No the D7 port is not abandon it wasn't really even started. It was a branch of the D6 version then I got busy again and didn't have a change to do much work on the D7 port. When drupal went from CVS to GIT the branch got enabled. I removed it because it isn't ready for testing. I am still working on the D7 port that lack of useful upgrade documentation has made upgrading very slow.

Thanks
Robert

threading_signals’s picture

threading_signals commented

Ok, thanks for the feedback Robert.

Looking forward to the finished project

Regards,

Paul

Drake’s picture

Drake commented

+1

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Title: Create Drupal 7 Version of this project. » Comment Closer for D7

Since the maintainer has multiple projects, changing the title makes it more clear.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Active » Needs review
StatusFileSize
new 870830-d7-comment-closer.patch30.29 KB

Here's a patch that gets us started. The settings work and cron (at least) does not fail. But we still need tests and to check that settings work properly.

The single *biggest* issue with this patch is that Drupal 7 will *not* allow the module name and function prefix to be different, so 'comment_closer' is now 'commentcloser' in all cases. Without this change, hook_form_alter() and other core hooks failed to fire.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
StatusFileSize
new 870830-d7-comment-closer.patch33.13 KB

Fixed an output format error, thanks to stub tests, in the patch.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Priority: Normal » Major
StatusFileSize
new 870830-d7-comment-closer.patch38.3 KB

And here's a patch with working tests for most functionality.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
StatusFileSize
new 870830-d7-comment-closer.patch39 KB

And a final (?) one that fixes the menu callback.

rmiddle’s picture

rmiddle commented

I just finished getting one of my other modules Drupal 7 port finished and went to look at this one and see someone has already done it :). Will hopefully look at this code this weekend and get a 7 port in place.

Thanks
Robert

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

I had a deadline :-)

rmiddle’s picture

rmiddle commented

agentrickard,

Most of your code has been merged in. I had already started my own build so there are some small diff. If you have a change pull the devel and test and see if this works ok for you.

Thanks
Robert

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Do the tests still pass? That's what I based my build on.

rmiddle’s picture

rmiddle commented

Good question I guess I should run them :)

Thanks
Robert

rmiddle’s picture

rmiddle commented

20 passes, 0 fails, 0 exceptions, and 2 debug messages

Looks like my changes are still compatible with your tests since I copy those directly in.

Thanks
Robert

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Right. I didn't even *use* the module. I just ported it, made it testable and then installed it.

I would call this closed and let people file new bugs.

rmiddle’s picture

rmiddle commented
Status: Needs review » Fixed

I am more interesting in people testing it right now but if you like writing test suits I have a few more modules that really need them :)

Thanks
Robert

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

I'll tell you, I don't like writing them but I love having them. It's a great benefit to development and I urge you to get into the habit.

That said, I barely have time for my own modules. Lucky you, my bosses want this module, and testing is actually the easiest way to validate that the code works as expected.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.