Few bugs related to --relative-assets switch

  • variable 'compass_relative_assets' is stored as 0/1, is not identical (===) to TRUE
  • same as '--boring' does not have parameter
  • '--relative-assets' does not work when the CWD is $_SERVER['DOCUMENT_ROOT'], what tested working are base_path() or path to theme

See patch.

CommentFileSizeAuthor
compass-relative_assets.patch1.28 KBckng

Comments

ckng’s picture

More info, I've inside the theme info

compass[sass_dir] = "scss"
compass[css_dir]  = "css"
compass[images_dir] = "images"

My theme folder structure is

/mytheme
- css/
- scss/
- images/

and of course, with Relative Assets checked.

Anonymous’s picture

Thanks! Your patch has been committed to the DRUPAL-6--1 branch. If I can make a new recommended release today, I will, but you should probably be running the dev branch for now anyway as it has some other fixes. In particular, it handles situations where Compass outputs more error messages than PHP could handle, which caused the process to hang.

Anonymous’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

ckng’s picture

Version: 6.x-1.x-dev » 6.x-1.0-beta2
Status: Closed (fixed) » Patch (to be ported)

This bug reappears in beta2.

ckng’s picture

Version: 6.x-1.0-beta2 » 6.x-1.x-dev
Status: Patch (to be ported) » Closed (fixed)

Mistaken, thought beta2 is newer release..