Support for hook_default_variables() [#871132]

A new feature is being worked on for Strongarm (#870040: Provide hook to allow modules to define what variables they own) which would help manage variable exporting, it'd be great if Auto_NodeTitle could support it.

Comment	File	Size	Author
#3	pathauto-n871132-v6x1x-2.patch	3.37 KB	damienmckenna
#3	pathauto-n871132-v6x2x-2.patch	3.02 KB	damienmckenna
#1	pathauto-n871132-v6x1x.patch	2.96 KB	damienmckenna
#1	pathauto-n871132-v6x2x.patch	2.87 KB	damienmckenna

Comments

Comment #1

damienmckenna

TN, USA

commented 2 August 2010 at 00:32

Status:

Active

» Needs work

Status	File	Size
new	pathauto-n871132-v6x2x.patch	2.87 KB
new	pathauto-n871132-v6x1x.patch	2.96 KB

Here are patches for v6.x-1.x and v6.x-2.x. FYI for the v6.x-2.x patch I did not verify that all of the variables from v6.x-1.x are still used, will do so shortly.

Comment #2

damienmckenna

TN, USA

commented 2 August 2010 at 00:44

Both patches are missing several variables for core Drupal functionality, updated patches on the way.

Comment #3

damienmckenna

TN, USA

commented 2 August 2010 at 01:09

Status:

Needs work

» Needs review

Status	File	Size
new	pathauto-n871132-v6x2x-2.patch	3.02 KB
new	pathauto-n871132-v6x1x-2.patch	3.37 KB

Updated patches that cover all of the variables created via the settings pages when all core modules are enabled.

Comment #4

greggles

he/him

English

Denver, Colorado, USA

commented 2 August 2010 at 14:00

Nitpick: The module name is Pathauto, not PathAuto.

Bigger question: I'm in favor of this idea, but not sure I see the value of this hook. Ideally I'd prefer to use a variable pattern like path_redirect and comment_notify where the name of the variable AND its default value is returned by this function. Any reason that strongarm doesn't work like that? It makes this function much more useful in general and makes people more likely to use it. Is there time to change it?