When locale is enabled and we have a node with multilingual support enabled comments should be assigned the current content language, but actually the value stored is always LANGUAGE_NONE. This was probably introduced by #635094: Unify "language neutral" language codes.

CommentFileSizeAuthor
#6 comment_language-871298-6.patch5.6 KBplach
#6 comment_language-871298-6-test.patch6.48 KBplach
#4 comment_language-871298-4.patch5.48 KBplach
#1 tf-871298-1.patch898 bytesplach

Comments

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Active » Needs review
Issue tags: +Quick fix
StatusFileSize
new tf-871298-1.patch898 bytes

Easy fix. Probably needs tests.

dries’s picture

dries commented
Priority: Critical » Normal
Status: Needs review » Needs work
Issue tags: -Quick fix +Needs tests

Committed to CVS HEAD. Moving to 'needs works' so we can add tests.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Title: Comment language not saved » Improve comment language test coverage

retitling

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs work » Needs review
StatusFileSize
new comment_language-871298-4.patch5.48 KB

Here are the tests.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Category: bug » task
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Issue tags: -Needs tests
StatusFileSize
new comment_language-871298-6-test.patch6.48 KB
new comment_language-871298-6.patch5.6 KB

Here is a rerolled patch.

The test-only version reverts the patch committed in #1 and is supposed to fail to show that the test captures the issue correctly.

Status: Needs review » Needs work

The last submitted patch, comment_language-871298-6-test.patch, failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs work » Reviewed & tested by the community

The green patch in #6 should be ready to go.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Lookgs good. Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.