Closed (fixed)
Project:
Apache Solr Search
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
2 Aug 2010 at 10:54 UTC
Updated:
3 Jan 2014 at 01:42 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jpmckinney commentedComment #2
jpmckinney commentedComment #3
jpmckinney commentedWow, was that function broken.
* $title undefined
* allowed access to $tids that the user may not have access to
* calls drupal_add_feed twice if it calls back to taxonomy_term_page
* uses search_help('search#noresults', drupal_help_arg()) instead of variable_get('apachesolr_search_noresults', apachesolr_search_noresults())
* and, as noted here, doesn't check user_access('search content')
Synced this function better with taxonomy_term_page
Comment #4
jpmckinney commentedSame patch applies to 6.x-2.x
Comment #5
jpmckinney commentedPatch for 7. Note that D7 doesn't fail back to taxonomy_term_page. It also doesn't have the check:
Comment #6
jpmckinney commentedUpdated D6 to set breadcrumb as in taxonomy_term_page.
Comment #7
jpmckinney commentedMerging #716104: Taxonomy hijack should fall back if SOLR is not present into this. Fixed watchdog error to be more descriptive, too.
Comment #8
jpmckinney commentedHopefully this will also fix #937398: Taxonomy Solr page: WSOD if no content has been indexed yet.
Comment #9
elliotttf commentedOne thing I did find, if using PHP 5.3 you'll get a strict warning on the taxonomy page. This problem actually exists in the taxonomy module too, but can be fixed by initializing the $current object before using it:
I've rerolled the patch with that one change but otherwise the patch looks good to me.
Comment #10
pwolanin commentedcommitted to 6.x-1.x and 6.x-2.x
not sure if some of the changes need to made also for 7.x.
Comment #11
jpmckinney commentedSee #5 :)
Comment #12
pwolanin commentedCommitting this for 7 - a couple minor tweaks.