_webform_submit_newsletter_email() uses the following code to determine whether the confirmation should be sent:

$confirm = $account->uid && $account->uid == $user->uid ? FALSE : TRUE;

However, simplenews version 2.x now also has the ability to have a single opt-in, not sending any confirmation (which we needed to use so we could use custom action triggers for this event).

Using the following code instead should fix this.

  if ($account->uid && $account->uid == $user->uid) {
    $confirm = FALSE;
  }
  else {
    $confirm = variable_get('simplenews_opt_inout_'. $news_vid, 'double') == 'double';
  }

This should be worked on for simplenews 1.x compatibility. In the meantime, expect a patch from skilip shortly.

CommentFileSizeAuthor
#6 webform_simplenews-871558-6-subscription-confirmation.patch1.56 KBvaartio
#1 webform_simplenews-871558-1.patch1.04 KBskilip

Comments

skilip’s picture

skilip commented
StatusFileSize
new webform_simplenews-871558-1.patch1.04 KB
pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Active » Fixed

Rolled against the dev version, thanks for the patch.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

I would recommend to add a note to the code that this is a 2.x feature.

@pcambra:
I still consider it best practice to put some information about simplenews release compatibility on your wsc front page. As soon as things go forward the question will soon be which branch/release supports which module.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented

I've just changed the description of the module to clarify version compatibility.
I'll add the comment to the file in the next bunch of patches.

Thanks @miro_dietiker

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

vaartio’s picture

vaartio commented
Status: Closed (fixed) » Patch (to be ported)
StatusFileSize
new webform_simplenews-871558-6-subscription-confirmation.patch1.56 KB

The patch above contains a little bug. Some cases $news_vid is an array and therefore $confirm = variable_get('simplenews_opt_inout_'. $news_vid, 'double') == 'double'; will never return false.
Attached is a patch which handles this problem.

vaartio’s picture

vaartio commented
Status: Patch (to be ported) » Needs review
rmcom’s picture

rmcom commented

Could a new version with all the working patches be rolled from dev to create v6.x-1.1?

joachim’s picture

joachim commented
Status: Needs review » Needs work

Patch has a lot of whitespace.

Also, if we're updating for 2.x, simplenews_subscribe_user() should pass a $source parameter.

rmcom’s picture

rmcom commented
Priority: Normal » Major

It would be greatly appreciated if a new release with the patches from the last 6-9 months could be released!