Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.
I looked over the patch, cause i recognized a bug concerning imagecache handling for imagecache presets containing a '_' in there names. An some preset names where used bei the image function right before they were set in the function.
I have reviewed the codebase for 6.x-5.x-dev and also for the 7.x branch.
However, the patch references the following file:
link_screenshot/link_screenshot.module
...which I do not see anywhere. Am I missing something?
The 6.x branch is no longer supported, but I am going to make some obvious bug fixes and add a couple of small enhancements anyway. I am also considering provided patches but this one confuses me. Please elaborate.
Update: I was checking out the "master" branch, which I assumed was the latest code. It may be, but there is no link_screenshot module in it. However, I see the link_screenshot module when I pull the 6.x-5.x branch.
So it may have been deprecated or the master branch may be out-of-sync. I am comparing versions and will get to the bottom of this. If it's been deprecated, then I'll close this ticket as "won't fix". Otherwise, I will look at getting the patch incorporated.
Comments
Comment #1
Methos76 commentedI looked over the patch, cause i recognized a bug concerning imagecache handling for imagecache presets containing a '_' in there names. An some preset names where used bei the image function right before they were set in the function.
So this patch is an improvment for the filters.
Comment #2
puravida commentedI have reviewed the codebase for 6.x-5.x-dev and also for the 7.x branch.
However, the patch references the following file:
link_screenshot/link_screenshot.module
...which I do not see anywhere. Am I missing something?
The 6.x branch is no longer supported, but I am going to make some obvious bug fixes and add a couple of small enhancements anyway. I am also considering provided patches but this one confuses me. Please elaborate.
Comment #3
puravida commentedUpdate: I was checking out the "master" branch, which I assumed was the latest code. It may be, but there is no link_screenshot module in it. However, I see the link_screenshot module when I pull the 6.x-5.x branch.
So it may have been deprecated or the master branch may be out-of-sync. I am comparing versions and will get to the bottom of this. If it's been deprecated, then I'll close this ticket as "won't fix". Otherwise, I will look at getting the patch incorporated.