Great module, Thanks.

I wrote a patch (file is attached) to disable ip2locale redirecting when the website is visited by a search engine robot or other crawler.

It has a dependency on the browscap module which is used for detecting search engines, etc.

The patch code uses the ip2locale debug setting (check box on the ip2locale admin page) for:

  • Showing if the browscap module is installed
  • Showing if a search engine robot was detected (thereby preventing a redirect)
  • Displaying the user-agent string (see the FireFox add-on User Agent Switcher for changing user-agents)

This is the first code I've posted back to Drupal on an issue queue (actually to any open source project). Any positive feedback would be appreciated.

All the best,
Guy Saban

CommentFileSizeAuthor
#5 ip2locale_detect_search_engine_dev.patch11.47 KBguysaban
#4 ip2locale_detect_search_engine_dev.patch11.47 KBguysaban
#6 ip2locale_dev_search_engine_detect.patch1.96 KBguysaban
ip2locale_detect_crawler.patch2.07 KBguysaban

Comments

guysaban’s picture

guysaban commented
Status: Patch (to be ported) » Needs review
guysaban’s picture

guysaban commented

Please find attached a patch file below for the the development version.

guysaban’s picture

guysaban commented

Added patch for dev. see #2 above.

PLEASE IGNORE - I DID NOT BUILD THE PATCH CORRECTLY - I'VE ATTACHED THE CORRECTED PATCH FILE FURTHER DOWN ON THIS ISSUE QUEUE.

guysaban’s picture

guysaban commented
StatusFileSize
new ip2locale_detect_search_engine_dev.patch11.47 KB

patch for dev version (9-August-2010)

PLEASE IGNORE - I DID NOT BUILD THE PATCH CORRECTLY - I'VE ATTACHED THE CORRECTED PATCH FILE FURTHER DOWN ON THIS ISSUE QUEUE.

guysaban’s picture

guysaban commented
StatusFileSize
new ip2locale_detect_search_engine_dev.patch11.47 KB

PLEASE IGNORE - I DID NOT BUILD THE PATCH CORRECTLY - I'VE ATTACHED THE CORRECTED PATCH FILE FURTHER DOWN ON THIS ISSUE QUEUE.

guysaban’s picture

guysaban commented
Version: 6.x-1.0-beta1 » 6.x-1.x-dev
StatusFileSize
new ip2locale_dev_search_engine_detect.patch1.96 KB

Please find attached the correct patch file for the dev version.

Sorry for making this queue messy.

guysaban’s picture

guysaban commented
Assigned: guysaban » Unassigned
mrfelton’s picture

mrfelton commented
Status: Needs review » Postponed (maintainer needs more info)

What is the problem with redirecting search engines? Why would you want to disable redirection for search engines?

guysaban’s picture

guysaban commented

Hi,

I have not researched this issue enough but my concern is how search engines will react to this feature.
Say Googlebot US visits the URL and then Googlebot UK visits the same URL but gets a redirect. How is that evaluated?

The issue with adding the option to avoid redirecting search engines is that of cloaking

At this point I am not sure whether redirecting or not redirecting search engines is a good idea.

All the best,
Guy