Fancy Login & Clean URLs [#872644]

Just helped someone on IRC with a problem not having clean urls with this module : action of the form generated by module was '?q=user/login?destination=node'

I don't have the time to make a proper patch file but here how I solved it :

fancy_login.module, replace line 29 by

			$clean_url = variable_get('clean_url', 0); 
			$fl_settings['destination'] = ($clean_url?'?':'?&').'destination=' . $_GET['q'];

in fancy_login.js, replace line 103 by

					targetHREF += Drupal.settings.fancyLogin.destination;

Since I don't use this module, this workaround has to be tested on multiple installations to make sure this doesn't affect anything else...

Regards,

Comments

Comment #1

jaypan

Victoria, BC

commented 3 August 2010 at 14:38

Got it, thanks.

Comment #2

jaypan

Victoria, BC

commented 25 August 2010 at 03:53

I tested this out, and it appears I had to change this piece of code:

$clean_url?'?':'?&'

To this:

$clean_url ? '?' : '&';

As adding a second question mark to the query on non-clean URLs was causing a problem. I have committed this to version 1.5. Thank you for informing me of this bug and contributing some code to fix it.